Closed Bug 1438953 Opened 2 years ago Closed 2 years ago
Timer Precision Tests need a more generous float fuzziness value
59 bytes, text/x-review-board-request
See https://bugzilla.mozilla.org/show_bug.cgi?id=1430841#c42 for something that should probably be addressed here.
Comment on attachment 8951713 [details] Bug 1438953 Increase the epsilon on timer reduction tests https://reviewboard.mozilla.org/r/220996/#review227238 This seems reasonable. Only shame is that we can't (or haven't yet) pull this out into common code. ::: commit-message-f191f:9 (Diff revision 1) > +numbers, where doubles can represent very precise decimals. They don't work for large numbers > +where doubles cannot represent such small decimals. This seems like an awkward way to express the idea that large doubles can't have precise fractional parts. WDYT about rewording this?
Attachment #8951713 - Flags: review?(nfroyd) → review+
2 years ago
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5db4200c90a8 Increase the epsilon on timer reduction tests r=froydnj
Backed out for failing mochitest at browser/components/resistfingerprinting/test/mochitest/test_animation_api.html Push that contains the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d32d276d2917d39471d8aa45192436f8819c5df0 failure log: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d32d276d2917d39471d8aa45192436f8819c5df0 Backout: https://hg.mozilla.org/integration/autoland/rev/ad3678a2943b860a240de123dc57520cf622572c
Okay, fixed the false positive case!
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/5eeff2b96802 Increase the epsilon on timer reduction tests r=froydnj
You need to log in before you can comment on or make changes to this bug.