Closed Bug 1439027 Opened 2 years ago Closed 2 years ago

Simplify PresShell::Initialize.

Categories

(Core :: Layout, enhancement, P3)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

Bug 1439027: Simplify PresShell::Initialize.
59 bytes, text/x-review-board-request
bzbarsky
: review+
Details 
This function takes two arguments just to set the pres context's visible area, and most people pass the pre-existing pres context visible area anyway.
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
Comment on attachment 8951795 [details]
Bug 1439027: Simplify PresShell::Initialize.

https://reviewboard.mozilla.org/r/221068/#review227726

::: layout/base/nsIPresShell.h:358
(Diff revision 1)
>    bool DidInitialize() const { return mDidInitialize; }
>  
>    /**
>     * Perform initialization. Constructs the frame for the root content
>     * object and then enqueues a reflow of the frame model into the
>     * specified width and height.

Please fix the docs; there is no specified width and height anymore, etc.
Attachment #8951795 - Flags: review?(bzbarsky) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a43a60bb3a90
Simplify PresShell::Initialize. r=bz
https://hg.mozilla.org/mozilla-central/rev/a43a60bb3a90
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.