Merge `Engine` and `SyncEngine`

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: lina, Assigned: lina)

Tracking

unspecified
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

These are currently different, for reasons™.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

Last year
mozreview-review
Comment on attachment 8951805 [details]
Bug 1439038 - Merge `Engine` and `SyncEngine`.

https://reviewboard.mozilla.org/r/221084/#review227304

Thank you for doing that, that split didn't make sense in our current implementation.

::: services/sync/modules/engines.js:1887
(Diff revision 2)
> +  async resetClient() {
> +    if (!this._resetClient) {
> +      throw new Error("engine does not implement _resetClient method");
> +    }
> +
> +    return this._notify("reset-client", this.name, this._resetClient)();

reset-client and wipe-client are only used in tests, it would be nice to replace them one day.
Attachment #8951805 - Flags: review?(eoger) → review+

Comment 4

Last year
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae61245586f7
Merge `Engine` and `SyncEngine`. r=eoger
https://hg.mozilla.org/mozilla-central/rev/ae61245586f7
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.