Closed
Bug 1439056
Opened 6 years ago
Closed 6 years ago
###!!! ASSERTION: Unexpected prototype node type: 'Not Reached', file /var/dev/erahm/mozilla-unified/dom/xul/nsXULPrototypeDocument.cpp, line 222
Categories
(Core :: XUL, enhancement)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
845 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Followup from bug 1439040, comment 3. We seem to be reading junk data after a failed read in `nsXULPrototypeDocument::Read`. Fixing this seems to get rid of some of the warnings in bug 1439040. I've verified that `type` value was junk in gdb and that the warning is bypassed if we break the loop on failure.
|
Assignee | |
Comment 1•6 years ago
|
||
We currently don't break out of a parsing loop on a read failure. This leads to us using a junk value further down.
Attachment #8951817 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8951817 [details] [diff] [review] Properly handle failure in nsXULPrototypeDocument::Read This code is horrible. And the changes from bug 777292 didn't exactly help... r=me on this part, I guess, but we should really fix all this error handling to be sane. :(
Attachment #8951817 -
Flags: review?(bzbarsky) → review+
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0b9ff594f771 Properly handle failure in nsXULPrototypeDocument::Read. r=bz
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b9ff594f771
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•