Closed Bug 1439061 Opened 4 years ago Closed 4 years ago
Properly clean up in history engine tests
59 bytes, text/x-review-board-request
The history tests create new instances of `HistoryEngine`, but don't clean up after themselves, so we have multiple trackers, and subsequent tests think it's not the first sync, since every instance uses a shared tracker file and prefs. Fixing this uncovered an issue in `test_history_visit_dedupe_old`, where we wouldn't upload the record with old visits on the first sync, because all its visits are older than 30 days, which is our cutoff for first syncs.
Comment on attachment 8951831 [details] Bug 1439061 - Stop tracking on engine finalization and clean up in history engine test. https://reviewboard.mozilla.org/r/221124/#review227640 LGTM!
Attachment #8951831 - Flags: review?(tchiovoloni) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/dcb4baced77a Stop tracking on engine finalization and clean up in history engine test. r=tcsc
You need to log in before you can comment on or make changes to this bug.