Closed Bug 1439063 Opened 4 years ago Closed 4 years ago

Move a few public headers from js/src into js/public

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Part 0: BitArray.h uses memset and therefore must #include <string.h>
738 bytes, patch
jandem
: review+
Details | Diff | Splinter Review
Part 1: Move several public headers from js/src to js/public
130.81 KB, patch
jandem
: review+
Details | Diff | Splinter Review
Part 2: Remove some unnecessary uses of js/Printf.h
18.60 KB, patch
jandem
: review+
Details | Diff | Splinter Review 
Affected: jsalloc.h, jsbytecode.h, jsprf.h, jsprototypes.h, jsversion.h, jswrapper.h

Also possibly jstypes.h and jspubtd.h.

I will not mess with jsapi.h and jsfriendapi.h.
Depends on: 1440043
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
js/src/jsalloc.h -> js/public/AllocPolicy.h
jsalloc.cpp -> js/src/util/AllocPolicy.cpp
jsbytecode.h -> merge into js/public/TypeDecls.h
jsprf.h -> js/public/Printf.h
jsprf.cpp -> js/src/util/Printf.cpp
jsprototypes.h -> public/ProtoKey.h
jswrapper.h -> js/Wrapper.h
Attachment #8953220 - Flags: review?(jdemooij)
Comment on attachment 8953220 [details] [diff] [review]
Part 1: Move several public headers from js/src to js/public

Review of attachment 8953220 [details] [diff] [review]:
-----------------------------------------------------------------

So much nicer.
Attachment #8953220 - Flags: review?(jdemooij) → review+
Attachment #8953221 - Flags: review?(jdemooij) → review+
Comment on attachment 8953219 [details] [diff] [review]
Part 0: BitArray.h uses memset and therefore must #include <string.h>

Review of attachment 8953219 [details] [diff] [review]:
-----------------------------------------------------------------

Oops forgot part 0.
Attachment #8953219 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7089df4b037451cd7cfa6176a0011ec50048d91c
Bug 1439063 - Part 0: BitArray.h uses memset and therefore must #include <string.h>. r=jandem.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ceb91c42b0ff876a61ed23f5e587ba3a2083bcf
Bug 1439063 - Part 1: Move several public headers from js/src to js/public. r=jandem.

https://hg.mozilla.org/integration/mozilla-inbound/rev/51fe9a44a5d3f1448cd7a2e50077e80ef919a3f3
Bug 1439063 - Part 2: Remove some unnecessary uses of js/Printf.h. r=jandem.
Depends on: 1441435
You need to log in before you can comment on or make changes to this bug.