1439092 - Buildbot builds and local builds busted with unresolved extern: _Servo_AuthorStyles_Drop

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Jorg K (CEST = GMT+2)]

The various platforms give various errors:

/builds/slave/tb-c-cen-l64-00000000000000000/build/objdir-tb/dist/include/mozilla/ServoBindingTypes.h:233: undefined reference to `Servo_AuthorStyles_Drop'

Undefined symbols for architecture x86_64:
  "_Servo_AuthorStyles_Drop", referenced from:
      __ZN23nsXBLPrototypeResourcesD2Ev in Unified_cpp_dom_xbl0.o
      __ZN23nsXBLPrototypeResources18ComputeServoStylesERKN7mozilla13ServoStyleSetE in Unified_cpp_dom_xbl0.o
ld: symbol(s) not found for architecture x86_64

Unified_cpp_dom_xbl0.obj : error LNK2019: unresolved external symbol _Servo_AuthorStyles_Drop referenced in function "public: __thiscall nsXBLPrototypeResources::~nsXBLPrototypeResources(void)" (??1nsXBLPrototypeResources@@QAE@XZ)

M-C last good: 941681a0ddc64f46dda9c2e69ea36a78bc
M-C first bad: c4d818c138689a66a397393fe1dd259ef0
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=941681a0ddc64f46dda9c2e69ea36a78bc&tochange=c4d818c138689a66a397393fe1dd259ef0

Looks like https://hg.mozilla.org/mozilla-central/rev/64edd64d9df8

Richard, Aceman: Can you still build, if so, what are your config specs?

Comment 1

[Richard Marti (:Paenglab)]

I'm in the middle of building...

TaskCluster seems to build, a m-c in c-c build issue?

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #1)
> TaskCluster seems to build, a m-c in c-c build issue?
No, it appears to be a Servo/Stylo disabled issue, like I have:
  ac_add_options --disable-stylo
If this option is still supported, maybe they missed #ifdef-ing something.

Comment 3

[Richard Marti (:Paenglab)]

Ah okay, here it's enabled.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1439092-servo.patch - NOT working

I tried to guard more and more Servo bits with #ifdef MOZ_OLD_STYLE, but without success.

Should we just assume that |ac_add_options --disable-stylo| isn't supported any more?

That would be bad for buildbot since we introduced this in bug 1350011 comment #10, see bug 1380171 comment #20. Bug 1380171 comment #19 says that the option is going away.

Comment 5

[Jorg K (CEST = GMT+2)]

I enabled Servo/Stylo not and after a |mach bootstrap| my build seems to be going now.

I'll leave the NI for Tom, he can close this or duplicate it to bug 1380171.

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm, after the next M-C merge, buildbot builds again. Weird. I'll leave this open so we can move to Servo soon.

Comment 7

[Jorg K (CEST = GMT+2)]

Fixed by https://hg.mozilla.org/mozilla-central/rev/715fefcb01d7
Bug 1439009: Declare a function in ServoBindingList to keep --disable-stylo happy. r=me

Comment 8

[:aceman]

Yes I could build without this bug appearing, on Linux 64bit, gcc7.
I do NOT disable stylo explicitly, but I use 'mach build' right now (gmake -f client.mk fails right now).

Comment 9

[Tom Prince [:tomprince]]

It appears that the Firefox mingw build also uses `--disable-stylo`, and so this got fixed for us upstream.