1439155 - .control:-moz-read-only matches inputs of type date and time event if not readonly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[davidetrisolini]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0.3 Safari/604.5.6

Steps to reproduce:

The CSS selector .control:-moz-read-only {border:0} matches <input type="date" class="control"> and <input type="time" class="control">, even if no readonly attribute is set on the elements.

Comment 1

[Stefan [:StefanG_QA]]

I think the correct component is Core::CSS: parsing and Computation. Please correct if this is not the right component.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This check doesn't include date / time inputs:

  https://searchfox.org/mozilla-central/rev/47cb352984bac15c476dcd75f8360f902673cb98/dom/html/nsGenericHTMLElement.cpp#2088

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1439155: Be consistent about what does readonly apply to.

Review commit: https://reviewboard.mozilla.org/r/222216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222216/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

There's another usage of IsTextOrNumberControl in:

  https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/dom/events/EventStateManager.cpp#1607

Do you know what the right thing to do there is Olli?

Comment 5

[Olli Pettay [:smaug]]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #4)
> There's another usage of IsTextOrNumberControl in:
> 
>  
> https://searchfox.org/mozilla-central/rev/
> 9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/dom/events/EventStateManager.
> cpp#1607
> 
> Do you know what the right thing to do there is Olli?

Looks like that code is used these days only in tests, as far as I see.
Given that we don't currently really deal with type=date specially in contextmenus, that code could just stay as it is, for now, I guess.

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 8952967 [details]
Bug 1439155: Be consistent about what does readonly apply to.

https://reviewboard.mozilla.org/r/222216/#review228308

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/443f765f134a
Be consistent about what does readonly apply to. r=smaug

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/443f765f134a