Closed Bug 1439181 Opened 3 years ago Closed 3 years ago

Stop mangling stack traces in AOM errors

Categories

(Toolkit :: Add-ons Manager, enhancement)

Product:
Toolkit
Component:
Add-ons Manager
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

Bug 1439181: Stop mangling stack traces in AOM errors.
59 bytes, text/x-review-board-request
aswan
: review+
Details 
Mangling stack traces into a single line is, I suppose, meant to be helpful. But in reality, it just makes the things impossible to read without demangling them.
Comment on attachment 8951941 [details]
Bug 1439181: Stop mangling stack traces in AOM errors.

https://reviewboard.mozilla.org/r/221212/#review227578

Thank you, I didn't actually test but this looks good to me.
However, this code appears to be used from many more places than just the addons manager.  Please send out a PSA to firefox-dev before landing so that nobody is surprised.
Attachment #8951941 - Flags: review?(aswan) → review+
https://hg.mozilla.org/mozilla-central/rev/99fd2c41687b
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.