1439181 - Stop mangling stack traces in AOM errors

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Kris Maglione [:kmag] (unavailable until 10/28)]

Mangling stack traces into a single line is, I suppose, meant to be helpful. But in reality, it just makes the things impossible to read without demangling them.

Comment 1

[Kris Maglione [:kmag] (unavailable until 10/28)]

Attachment: Bug 1439181: Stop mangling stack traces in AOM errors.

Review commit: https://reviewboard.mozilla.org/r/221212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221212/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8951941 [details]
Bug 1439181: Stop mangling stack traces in AOM errors.

https://reviewboard.mozilla.org/r/221212/#review227578

Thank you, I didn't actually test but this looks good to me.
However, this code appears to be used from many more places than just the addons manager.  Please send out a PSA to firefox-dev before landing so that nobody is surprised.

Comment 3

[Kris Maglione [:kmag] (unavailable until 10/28)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99fd2c41687b7a9f7912a2b74b1eaaf4fa7a96f9
Bug 1439181: Stop mangling stack traces in AOM errors. r=aswan

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/99fd2c41687b

Comment 5

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.