Closed Bug 1439250 Opened 2 years ago Closed 2 years ago

Port bug 1431189 to TB: Add google chrome toolbar button color properties

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 60.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

In bug 1431189 FX added the ability to theme the hovered and active toolbar buttons.
This is a port of https://hg.mozilla.org/mozilla-central/rev/749425381bba but we are too different to make a 1-to-1 port. They also removed later the theming of not-hovered/not active toolbar buttons.

The windows part is mostly only moving a block to be more in synch with the other platforms. Linux and Mac are code wise synched with Windows to make the rules similar.

The primaryToolbar.css changes are to make the icons in the write button, with Lightning enabled, not get the theming colors.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8952007 - Flags: review?(jorgk)
Apparently FF implemented color.button_background, color.button_background_hover, color.button_background_active.
Do you have a theme to try this in TB?
As I wrote in comment 1, FX removed color.button_background in a later bug. The last test theme from bug 1439134 has this already implemented, again with very nice colors. ;)
Comment on attachment 8952007 [details] [diff] [review]
LW-button-colors.patch

Yes, active and hovered toolbar buttons get the configured colour, active and hovered at the same time can also be distinguished.
Attachment #8952007 - Flags: review?(jorgk) → review+
Thanks.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e272e60f53c6
Port bug 1431189 to TB: Add google chrome toolbar button color properties. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.