1439362 - make nsBase64Encoder slightly less malloc-happy

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Nathan Froyd [:froydnj]]

nsBase64Encoder::Finish currently works by calling PL_Base64Encode to
allocate a base64-encoded string, then Assign()'ing that to the result
string, another allocation.  mozilla::Base64Encode enables us to base64
encode directly into the result string with a single allocation, saving
an allocation.  (Base64Encode is also slightly more efficient, because
we don't have to do a strlen() on the string being Assign()'d.)  Let's
use Base64Encode instead.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make nsBase64Encoder slightly less malloc-happy

A small improvement, but a nice one.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43b8d13b9961
make nsBase64Encoder slightly less malloc-happy; r=valentin

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/43b8d13b9961