Closed Bug 1439371 Opened 2 years ago Closed 2 years ago

Cannot close browser console with cmd+w when using new-frontend

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jdescottes, Assigned: bgrins)

References

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

(Haven't checked other OSes than MacOS)

STRs:
- set devtools.browserconsole.new-frontend-enabled to true
- open Browser Console
- press cmd+W

ER: Browser Console window should close itself
AR: Browser Console still open
Priority: -- → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8952235 [details]
Bug 1439371 - Close the top window (browserconsole.xul) when the close key shortcut is used in the Browser Console;

https://reviewboard.mozilla.org/r/221488/#review227364

Works well, thanks!
Attachment #8952235 - Flags: review?(jdescottes) → review+
Blocks: 1437854
Test should be handled in Bug 1437854
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56763cbe3a0b
Close the top window (browserconsole.xul) when the close key shortcut is used in the Browser Console;r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/56763cbe3a0b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
QA Whiteboard: [good first verify]
I've managed this issue on Nightly 60.0a1 (2018-02-19) (Build ID: 20180219100221) in Linux,64 bit

I can confirm this issue is now verified as fixed on Latest Firefox Dev Edition 60.0b14 (64-bit)

Build ID : 20180419200216
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
QA Whiteboard: [good first verify] → [good first verify] [testday-20180420]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.