1439371 - Cannot close browser console with cmd+w when using new-frontend

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Julian Descottes [:jdescottes]]

(Haven't checked other OSes than MacOS)

STRs:
- set devtools.browserconsole.new-frontend-enabled to true
- open Browser Console
- press cmd+W

ER: Browser Console window should close itself
AR: Browser Console still open

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1439371 - Close the top window (browserconsole.xul) when the close key shortcut is used in the Browser Console;

In the old frontend `this.window.close` worked since webconsole.xul was used for both the web console
and browser console. The new frontend is implemented in HTML (webconsole.html) but for the browser console
we wrap that in a XUL document (browserconsole.xul) to support window management and other XUL features.
So when the HTML frontend receieves cmd/ctrl+w, we now call the `close` function for the XUL window instead.

Review commit: https://reviewboard.mozilla.org/r/221488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221488/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8952235 [details]
Bug 1439371 - Close the top window (browserconsole.xul) when the close key shortcut is used in the Browser Console;

https://reviewboard.mozilla.org/r/221488/#review227364

Works well, thanks!

Comment 3

[Julian Descottes [:jdescottes]]

Test should be handled in Bug 1437854

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56763cbe3a0b
Close the top window (browserconsole.xul) when the close key shortcut is used in the Browser Console;r=jdescottes

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/56763cbe3a0b

Comment 6

[Nazir Ahmed Sabbir [:NaSb]]

I've managed this issue on Nightly 60.0a1 (2018-02-19) (Build ID: 20180219100221) in Linux,64 bit

I can confirm this issue is now verified as fixed on Latest Firefox Dev Edition 60.0b14 (64-bit)

Build ID : 20180419200216
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0