1439373 - [CSD] Wrong colour used for main panel tabs

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Juraj Fiala]

Attachment: comparison.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180130211649

Steps to reproduce:

The colour is far too dark, different to both the tab borders and the colour used in GTK+ HeaderBars.

See the screenshot for a comparison using Adwaita 3.26.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

The GtkHeaderBar background color is the same (244, 244, 244). Tabs has different colors because those are styled by Firefox itself - not sure if we can change tab color.

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot

I think the problem is not in the color of tabs, but in the shadow at the bottom of the tab strip. On the screenshot left without CSD, right with CSD.

Comment 3

[Juraj Fiala]

Attachment: “enhanced” screenshot

> I think the problem is not in the color of tabs, but in the shadow at the bottom of the tab strip. On the screenshot left without CSD, right with CSD.

Yes, exactly.

Comment 4

[Juraj Fiala]

Attachment: screenshot with extra drag space enabled

I think I found the culprit – looks like there are two transparent borders overlapping each other. Also, the newest patch didn’t fix the issue for the drag space basically being enabled all the time on Adwaita.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to Juraj Fiala from comment #4)
> Created attachment 8952367 [details]
> screenshot with extra drag space enabled
> 
> I think I found the culprit – looks like there are two transparent borders
> overlapping each other. Also, the newest patch didn’t fix the issue for the
> drag space basically being enabled all the time on Adwaita.

That's solved at Bug 1434621

Comment 6

[Martin Stránský [:stransky] (ni? me)]

(In reply to Juraj Fiala from comment #4)
> Created attachment 8952367 [details]
> screenshot with extra drag space enabled
> 
> I think I found the culprit – looks like there are two transparent borders
> overlapping each other. Also, the newest patch didn’t fix the issue for the
> drag space basically being enabled all the time on Adwaita.

Filed Bug 1439834 for it as Bug 1434621 has only a partial fix.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Please check if it's fixed after Bug 1439834 land.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Closing per #7, please reopen if you still see that.