Closed
Bug 1439398
Opened 6 years ago
Closed 6 years ago
Upstream a few more ib-split reftests.
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Just another tad of lazy time I had this afternoon.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8952188 [details] Bug 1439398: Tidy a few more tests in preparation to upstreaming. https://reviewboard.mozilla.org/r/221430/#review227226 r=dbaron with the following tweaks, although I don't think the reindentation, removal of <html> and <body> tags, and onload script cleanup is actually necessary... ::: layout/reftests/ib-split/whitespace-present-1-ref.html:7 (Diff revision 1) > -<html> > - <head> > +<meta charset="utf-8"> > +<title>CSS Test Reference</title> > +<link rel="author" title="Boris Zbarsky" href="mailto:bzbarsky@mit.edu"> > +<link rel="author" title="Mozilla Corporation" href="http://mozilla.com/"> > - <style> > +<style> > - body > span { border: 3px solid blue } > + span { border: 3px solid blue } This selector might have been intended this way in order to make sure the span was a child of body in the DOM (rather than having HTML-level fixup). I think it's better to leave it. ::: layout/reftests/ib-split/whitespace-present-1a.html:9 (Diff revision 1) > - <link rel="author" title="Boris Zbarsky" href="mailto:bzbarsky@mit.edu" /> > - <link rel="author" title="Mozilla Corporation" href="http://mozilla.com/" /> > - <link rel="help" href="http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level"/> > - <meta name="flags" content="" /> > +<link rel="author" title="Boris Zbarsky" href="mailto:bzbarsky@mit.edu"> > +<link rel="author" title="Mozilla Corporation" href="http://mozilla.com/"> > +<link rel="help" href="http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level"> > +<link rel="match" href="whitespace-present-1-ref.html"> > - <style> > +<style> > - body > span { border: 3px solid blue } > + span { border: 3px solid blue } same here ::: layout/reftests/ib-split/whitespace-present-1b.html:9 (Diff revision 1) > - <link rel="author" title="Boris Zbarsky" href="mailto:bzbarsky@mit.edu" /> > - <link rel="author" title="Mozilla Corporation" href="http://mozilla.com/" /> > - <link rel="help" href="http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level"/> > - <meta name="flags" content="dom" /> > +<link rel="author" title="Boris Zbarsky" href="mailto:bzbarsky@mit.edu"> > +<link rel="author" title="Mozilla Corporation" href="http://mozilla.com/"> > +<link rel="help" href="http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level"> > +<link rel="match" href="whitespace-present-1-ref.html"> > - <style> > +<style> > - body > span { border: 3px solid blue } > + span { border: 3px solid blue } same here
Attachment #8952188 -
Flags: review?(dbaron) → review+
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8952189 [details] Bug 1439398: Upstream a few more ib-split tests. https://reviewboard.mozilla.org/r/221432/#review227228 This seems to be on top of a patch that hasn't landed yet... but please make sure that ib-split/reftest.list is included in layout/reftests/w3c-css/submitted/reftest.list when you land, no matter which order you land in.
Attachment #8952189 -
Flags: review?(dbaron) → review+
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/77cedae32cfa Tidy a few more tests in preparation to upstreaming. r=dbaron https://hg.mozilla.org/integration/autoland/rev/15608da1612b Upstream a few more ib-split tests. r=dbaron
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/77cedae32cfa https://hg.mozilla.org/mozilla-central/rev/15608da1612b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
This had a lint failure when I tried upstreaming it in https://github.com/w3c/web-platform-tests/pull/10358 , see https://travis-ci.org/w3c/web-platform-tests/jobs/363645855 which says: css/vendor-imports/mozilla/mozilla-central-reftests/ib-split/table-pseudo-in-part3-1-ref.html:11: Whitespace at EOL (TRAILING WHITESPACE) ERROR:lint:css/vendor-imports/mozilla/mozilla-central-reftests/ib-split/table-pseudo-in-part3-1-ref.html:11: Whitespace at EOL (TRAILING WHITESPACE)
Flags: needinfo?(emilio)
Actually, I'll just fix this on inbound...
Flags: needinfo?(emilio)
Comment 10•6 years ago
|
||
Pushed by dbaron@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bee5d7ed00d7 followup: remove trailing space to satisfy web-platform-tests lint. No review (trivial and test-only).
https://hg.mozilla.org/integration/mozilla-inbound/rev/bee5d7ed00d733fa98710f5578983dd43094b1e0 Bug 1439398 followup: remove trailing space to satisfy web-platform-tests lint. No review (trivial and test-only).
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bee5d7ed00d7
You need to log in
before you can comment on or make changes to this bug.
Description
•