Closed
Bug 1439403
Opened 6 years ago
Closed 6 years ago
Miscellaneous ARM64 support
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(1 file)
|
9.13 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
Platform flags, stubbed-out disassembler stubs (for non-present asm.js support), and high-level platform configuration.
|
Assignee | |
Comment 1•6 years ago
|
||
Odds and ends to make everything hang together, more info in commit msg.
Attachment #8954028 -
Flags: review?(bbouvier)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8954028 [details] [diff] [review] bug1439403-spidermonkey-wasm-arm64-general.patch Review of attachment 8954028 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. ::: js/src/wasm/WasmJS.cpp @@ +35,3 @@ > #include "wasm/WasmCompile.h" > #include "wasm/WasmInstance.h" > +#include "wasm/WasmIonCompile.h" Are these includes necessary for non-unified build in general/on ARM64? (otherwise could we remove them)
Attachment #8954028 -
Flags: review?(bbouvier) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Benjamin Bouvier [:bbouvier] from comment #2) > Comment on attachment 8954028 [details] [diff] [review] > bug1439403-spidermonkey-wasm-arm64-general.patch > > Review of attachment 8954028 [details] [diff] [review]: > ----------------------------------------------------------------- > > Thanks. > > ::: js/src/wasm/WasmJS.cpp > @@ +35,3 @@ > > #include "wasm/WasmCompile.h" > > #include "wasm/WasmInstance.h" > > +#include "wasm/WasmIonCompile.h" > > Are these includes necessary for non-unified build in general/on ARM64? > (otherwise could we remove them) They are necessary for a non-unified build in general, and they actually landed yesterday as fixup for bustage on an earlier patch :) They got merged to the wrong patch in my queue.
Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a2507d4da91b General SpiderMonkey support for wasm on ARM64. r=bbouvier
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a2507d4da91b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•