Closed Bug 1439403 Opened 2 years ago Closed 2 years ago

Miscellaneous ARM64 support

Categories

(Core :: JavaScript Engine, enhancement, P3)

ARM64
All
enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

Platform flags, stubbed-out disassembler stubs (for non-present asm.js support), and high-level platform configuration.
Odds and ends to make everything hang together, more info in commit msg.
Attachment #8954028 - Flags: review?(bbouvier)
Comment on attachment 8954028 [details] [diff] [review]
bug1439403-spidermonkey-wasm-arm64-general.patch

Review of attachment 8954028 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: js/src/wasm/WasmJS.cpp
@@ +35,3 @@
>  #include "wasm/WasmCompile.h"
>  #include "wasm/WasmInstance.h"
> +#include "wasm/WasmIonCompile.h"

Are these includes necessary for non-unified build in general/on ARM64? (otherwise could we remove them)
Attachment #8954028 - Flags: review?(bbouvier) → review+
(In reply to Benjamin Bouvier [:bbouvier] from comment #2)
> Comment on attachment 8954028 [details] [diff] [review]
> bug1439403-spidermonkey-wasm-arm64-general.patch
> 
> Review of attachment 8954028 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks.
> 
> ::: js/src/wasm/WasmJS.cpp
> @@ +35,3 @@
> >  #include "wasm/WasmCompile.h"
> >  #include "wasm/WasmInstance.h"
> > +#include "wasm/WasmIonCompile.h"
> 
> Are these includes necessary for non-unified build in general/on ARM64?
> (otherwise could we remove them)

They are necessary for a non-unified build in general, and they actually landed yesterday as fixup for bustage on an earlier patch :)  They got merged to the wrong patch in my queue.
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2507d4da91b
General SpiderMonkey support for wasm on ARM64.  r=bbouvier
https://hg.mozilla.org/mozilla-central/rev/a2507d4da91b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.