Closed Bug 1439429 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 9573 - ReadableStream: Add a test that all queued writes complete when closing after first write and preventClose = true

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9573 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9573
Details from upstream follow.

Mattias Buelens wrote:
>  ReadableStream: Add a test that all queued writes complete when closing after first write and preventClose = true
>  
>  This PR adds another test for the new behavior introduced in whatwg/streams#884, namely that all queued writes must complete before a pipe operation becomes completed.
>  
>  When the readable stream closes, the pipe operation should wait for all writes to complete, then close the writable stream (only if `preventClose != true`), and then resolve the pipe operation's promise. The new test checks the handling of `preventClose = true`, since this case was previously not handled correctly by the reference implementation.
>  
>  The new test is very similar to the one added in #5636, which verifies similar behavior for when the readable stream becomes errored.
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 4 tests and 113 subtests
OK     : 4
PASS   : 1
FAIL   : 112

New tests that have failures or other problems:
/streams/piping/close-propagation-forward.dedicatedworker.html
    Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write; preventClose = true: FAIL
/streams/piping/close-propagation-forward.html
    Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write; preventClose = true: FAIL
/streams/piping/close-propagation-forward.serviceworker.https.html
    Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write; preventClose = true: FAIL
/streams/piping/close-propagation-forward.sharedworker.html
    Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write; preventClose = true: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26e19867bbdb
[wpt PR 9573] - ReadableStream: Add a test that all queued writes complete when closing after first write, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/f20f366d0374
[wpt PR 9573]- Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/26e19867bbdb
https://hg.mozilla.org/mozilla-central/rev/f20f366d0374
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.