Closed Bug 1439449 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 9575 - WebDriver: fix some issues in fullscreen tests

Categories

(Testing :: geckodriver, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9575 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9575
Details from upstream follow.

Brian Burg wrote:
>  WebDriver: fix some issues in fullscreen tests
>  
>  The test test_handle_prompt_accept seems to think that the
>  Fullscreen Window command returns the window title, which is
>  not the case. Remove wrong assertions. The return payload is
>  checked by a different test case.
>  
>  The test test_handle_prompt_missing_value has a typo in a
>  global variable lookup. This throws a JS exception at runtime.
>  
>  Tests that use window.fullScreen fail when run in WebKit because
>  WebKit does not yet conform to the Fullscreen API, and its existing
>  properties and methods are prefixed. Add a fallback and a note
>  with the WebKit bug that blocks removing this fallback.
Component: web-platform-tests → geckodriver
Ran 1 tests and 9 subtests
OK     : 1
PASS   : 8
FAIL   : 1

New tests that have failures or other problems:
/webdriver/tests/fullscreen_window.py
    test_handle_prompt_accept: FAIL[linux64-debug]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53978eb05f07
[wpt PR 9575] - WebDriver: fix some issues in fullscreen tests, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/077dea03b224
[wpt PR 9575]- Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/53978eb05f07
https://hg.mozilla.org/mozilla-central/rev/077dea03b224
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.