Closed
Bug 1439449
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 9575 - WebDriver: fix some issues in fullscreen tests
Categories
(Testing :: geckodriver, enhancement, P3)
Testing
geckodriver
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 9575 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/9575 Details from upstream follow. Brian Burg wrote: > WebDriver: fix some issues in fullscreen tests > > The test test_handle_prompt_accept seems to think that the > Fullscreen Window command returns the window title, which is > not the case. Remove wrong assertions. The return payload is > checked by a different test case. > > The test test_handle_prompt_missing_value has a typo in a > global variable lookup. This throws a JS exception at runtime. > > Tests that use window.fullScreen fail when run in WebKit because > WebKit does not yet conform to the Fullscreen API, and its existing > properties and methods are prefixed. Add a fallback and a note > with the WebKit bug that blocks removing this fallback.
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → geckodriver
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8163db849fed1c187a3ba647ab6849882d484673
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1569df3468da3ad3b5b4e4721c73d7597b367e3
Reporter | ||
Comment 3•6 years ago
|
||
Ran 1 tests and 9 subtests OK : 1 PASS : 8 FAIL : 1 New tests that have failures or other problems: /webdriver/tests/fullscreen_window.py test_handle_prompt_accept: FAIL[linux64-debug]
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/53978eb05f07 [wpt PR 9575] - WebDriver: fix some issues in fullscreen tests, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/077dea03b224 [wpt PR 9575]- Update wpt metadata, a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/53978eb05f07 https://hg.mozilla.org/mozilla-central/rev/077dea03b224
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•