Closed Bug 1439538 Opened 2 years ago Closed 2 years ago

Convert nsHostResolver::m{High,Medium,Low,Eviction}Q to LinkedList<RefPtr<nsHostRecord>>

Categories

(Core :: Networking, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Using PRCList is error prone. LinkedList is much better.
Attachment #8952418 - Flags: review?(daniel)
I tried to keep the behaviour as close to the previous one, but I also noticed that nsHostRecord::onQueue isn't updated everytime we remove a record from the queue - such as in TrrLookup(), NativeLookup(), CancelAsyncRequest(), FlushCache()
This is probably because we assume the last reference will delete the object, but that might not always be true. Could this cause some issues?
Flags: needinfo?(daniel)
I think as long as 'OnQueue' is false for the entries that are being resolved right now everything should be fine. That seems to be the sole function for that member.
Flags: needinfo?(daniel)
Comment on attachment 8952418 [details]
Bug 1439538 - Convert nsHostResolver::m{High,Medium,Low,Eviction}Q to LinkedList<RefPtr<nsHostRecord>>

https://reviewboard.mozilla.org/r/221656/#review227664
Attachment #8952418 - Flags: review?(daniel) → review+
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/58a485627c5e
Convert nsHostResolver::m{High,Medium,Low,Eviction}Q to LinkedList<RefPtr<nsHostRecord>> r=bagder
https://hg.mozilla.org/mozilla-central/rev/58a485627c5e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1438904
Blocks: 1439096
Blocks: 1439130
You need to log in before you can comment on or make changes to this bug.