1439565 - Update webrender to 8a19316a733a484bf9bafb8257e3008b1418bfe4

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1438892 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 3797d9c9c28f93738bb037cddadee6c1e72e85e0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=007010cd3ae5a826a78269784e0c548916cb63b3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7db8822e44bf17b9cce2e8eb7ffbb39fe509460

Green

Comment 2

[Glenn Watson [:gw]]

FYI - https://github.com/servo/webrender/pull/2441#issuecomment-367211596

Comment 3

[Glenn Watson [:gw]]

I still haven't managed to reproduce the failures referenced above. However, I'm not sure it's related to that gradient patch now - there's several other tests in R4 that appear to only be failing in debug mode, and many of them don't have any gradients in them. I'll keep trying to reproduce locally and investigating tomorrow.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 3797d9c9c28f93738bb037cddadee6c1e72e85e0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddc8f978d3bfb1b75a40631486130ac10ba0ef38
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbae0fbb6808af8fbea75a00496bb2a39c5058a1

Green

WR @ 2d2d7b7f293eaac2b463fe0e61a7face9253053e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c1d576ae6c701b62efc56619583b175c3898c84
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3824fdb735b4606c76e8eb9d66a5f07a2f09cdb3

R4 debug linux failures, and windows opt reftest went red (also because there was an increase in failures, and it hit the max log size). From servo/webrender#2441 as Glenn noted above.

WR @ c7778751c13ebe40c562e174c19a0e95cdc6a895

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44ecb718fc801aa29285d6e7513d657f01c1ccaf
https://treeherder.mozilla.org/#/jobs?repo=try&revision=61a2d800f8357868896171ed7e4c86e517c083ec

R4 linux failures have spread to opt as well. So I guess it's not specific to debug, but is likely a race condition that gets triggered more often on debug than opt.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Bisection try push to confirm whether the R4 failures are coming from servo/webrender#2441 or servo/webrender#2444 : WR @ b2acbc94943810b8a93e5bb9a3f4c0ccc446379e (this includes #2444 but not #2441)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e34663d5ac99e273b2c5fd56a2cd0de3ebe5b836
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a58bd244f80e992ffcd3d635056967b8ee7dfc3

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Retriggers and bisection confirm it's from #2441.

Regular try pushes continuing:

WR @ d2037769b7cd5c2bbd67c0c48ca854f5e189f19f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=50c9473eff9aac997927a0491839bcba721c3df3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a662d717513df3eb49125cfec3a4fd9d5c64ffc

Same as before

WR @ 99e18ff0b56ba1a5ec9b1fdf31119af05f5074d3 (this has glenn's fix for the R4 failure in servo/webrender#2454):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd28076a6758ca9cf739b9f8f178a39fb29a6c71
https://treeherder.mozilla.org/#/jobs?repo=try&revision=de95545a4c9d2090aaec0ec76a3ab4ab939dca40

R4 failure is indeed fixed, \o/

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 8a19316a733a484bf9bafb8257e3008b1418bfe4

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2c0d91c2fef35bea888505733b98c824c92110c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a66762cfa379627de3f8f87f8c546b035c9ccb6

Bunch of fuzziness changes, from servo/webrender#2445. The only weird thing is the R4 one seems to be bimodal in that mostly it has 8924 pixels that are different, but sometimes it has only 8772. I can cover it with a fuzzy range but I'm worried it's masking some underlying nondeterminism that we should address.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 8a19316a733a484bf9bafb8257e3008b1418bfe4 with fuzzy annotations

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d4d46b139c3363ca7b2bb918fa953e5b1d506af
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3bd679fffea4f107be29764cbc031fcb6d57cfc

Green so far

WR @ 992dbd3f07b143f35581012082aa59fbda7c387e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f32f7a61788f975ed321a4cd3cf7bd7d5815cd91
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c13598e90f38ec162733660d793d2a132d853a50

Worrying amount of orange there. From servo/webrender#2362 - nical's async scene building stuff.

Comment 9

[Nicolas Silva [:nical]]

There's a lot of aa-related failures which I assume come from https://github.com/servo/webrender/pull/2445 and some bigger differences that most likely come from async scene building. I did find at least one mistake in the async scene building code that may cause epochs to be delayed by one frame some of the time and could explain at least some of the issues here.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

All the AA failures from #2445 were annotated in all the try pushes listed in comment 8. The orange there should be all from your async scene building stuff.

I'm going to do an update to just before your async scene stuff landed.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1439565 - Update webrender to commit 8a19316a733a484bf9bafb8257e3008b1418bfe4.

Review commit: https://reviewboard.mozilla.org/r/222684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222684/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1439565 - Update reftest annotations for changes in WR PR 2445.

Review commit: https://reviewboard.mozilla.org/r/222686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222686/

Comment 13

[Jeff Muizelaar [:jrmuizel] [Parental leave until Sept 21]]

Comment on attachment 8953431 [details]
Bug 1439565 - Update webrender to commit 8a19316a733a484bf9bafb8257e3008b1418bfe4.

https://reviewboard.mozilla.org/r/222684/#review228648

Comment 14

[Jeff Muizelaar [:jrmuizel] [Parental leave until Sept 21]]

Comment on attachment 8953432 [details]
Bug 1439565 - Update reftest annotations for changes in WR PR 2445.

https://reviewboard.mozilla.org/r/222686/#review228646

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a32ca63e380
Update webrender to commit 8a19316a733a484bf9bafb8257e3008b1418bfe4. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5eb19c81c7fd
Update reftest annotations for changes in WR PR 2445. r=jrmuizel

Comment 16

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3a32ca63e380
https://hg.mozilla.org/mozilla-central/rev/5eb19c81c7fd