1439578 - Wasm baseline: Do not generate out-of-line code if it is not referenced

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

On ARM64 the saturating truncation ops have exactly the same semantics, so there is never a need to go out-of-line to handle special cases.  Yet the baseline compiler will generate out-of-line code because it does not know that.

However, since the out-of-line code is generated late, we should be able to avoid generating it if its entry label is never referenced, as it won't be for the saturating ops.

The alternative to sniffing at the entry label is to export some kind of predicate from MacroAssembler.h or to have ifdefs in the baseline compiler that "knows" this, but both of those cross the compiler/masm boundary in unpleasant ways.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1439578 - wasm: Don't emit OOL code if it's not used. r?lth

This commit implements the simple approach of not emitting an
OOL stub for baseline if it's entry label is not used.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/165bc67e941d
wasm: Don't emit OOL code if it's not used. r=lth

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/165bc67e941d