1439640 - build bustage in opt builds' browser/defaults/preferences/firefox-branding.js when Gecko 60 merges to Beta on 2018-03-01

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1435458 added preprocessing to browser/defaults/preferences/firefox-branding.js

The file actually has preprocessing: https://dxr.mozilla.org/mozilla-central/rev/dc70d241f90df43505ece5ac12261339e9694c50/browser/branding/official/pref/firefox-branding.js

But this 'central as beta' Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=795756d582732b2acecc5278908e7d3b389c4cc4&selectedJob=163224775

has the opt build jobs failing with: https://treeherder.mozilla.org/logviewer.html#?job_id=163224775&repo=try&lineNumber=26477

[task 2018-02-20T15:59:44.292Z] 15:59:44     INFO -  make[5]: *** Deleting file '../../../dist/bin/browser/defaults/preferences/firefox-branding.js'
[task 2018-02-20T15:59:44.293Z] 15:59:44     INFO -  make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/browser/branding/official'
[task 2018-02-20T15:59:44.293Z] 15:59:44     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python -m mozbuild.action.preprocessor --depend .deps/firefox-branding.js.pp  -DNDEBUG=1 -DTRIMMED=1 -DACCESSIBILITY=1 -DATK_MAJOR_VERSION=2 -DATK_MINOR_VERSION=4 -DATK_REV_VERSION=0 -DBUILD_CTYPES=1 -DCROSS_COMPILE='' -DEARLY_BETA_OR_EARLIER=1 -DENABLE_INTL_API=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DENABLE_TESTS=1 -DEXPOSE_INTL_API=1 -DFIREFOX_VERSION=60.0 -DFORCE_PR_LOG=1 -DFUNCPROTO=15 -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_3_4 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_PROVIDER_GLX=1 -DGTEST_HAS_RTTI=0 -DHAVE_64BIT_BUILD=1 -DHAVE_ALLOCA_H=1 -DHAVE_BYTESWAP_H=1 -DHAVE_CLOCK_MONOTONIC=1 -DHAVE_CPUID_H=1 -DHAVE_DIRENT_H=1 -DHAVE_DLADDR=1 -DHAVE_DLOPEN=1 -DHAVE_FONTCONFIG_FCFREETYPE_H=1 -DHAVE_FT_BITMAP_SIZE_Y_PPEM=1 -DHAVE_FT_GLYPHSLOT_EMBOLDEN=1 -DHAVE_FT_LOAD_SFNT_TABLE=1 -DHAVE_GETOPT_H=1 -DHAVE_GMTIME_R=1 -DHAVE_INTTYPES_H=1 -DHAVE_LCHOWN=1 -DHAVE_LINUX_IF_ADDR_H=1 -DHAVE_LINUX_PERF_EVENT_H=1 -DHAVE_LINUX_QUOTA_H=1 -DHAVE_LINUX_RTNETLINK_H=1 -DHAVE_LOCALECONV=1 -DHAVE_LOCALTIME_R=1 -DHAVE_LSTAT64=1 -DHAVE_MALLINFO=1 -DHAVE_MALLOC_H=1 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MEMALIGN=1 -DHAVE_MEMMEM=1 -DHAVE_NETINET_IN_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_POSIX_FADVISE=1 -DHAVE_POSIX_FALLOCATE=1 -DHAVE_POSIX_MEMALIGN=1 -DHAVE_PTHREAD_H=1 -DHAVE_RES_NINIT=1 -DHAVE_SETPRIORITY=1 -DHAVE_STAT64=1 -DHAVE_STDINT_H=1 -DHAVE_STRERROR=1 -DHAVE_STRNDUP=1 -DHAVE_SYSCALL=1 -DHAVE_SYS_QUEUE_H=1 -DHAVE_SYS_QUOTA_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_THREAD_TLS_KEYWORD=1 -DHAVE_TRUNCATE64=1 -DHAVE_UNISTD_H=1 -DHAVE_VALLOC=1 -DHAVE_VA_COPY=1 -DHAVE_VA_LIST_AS_ARRAY=1 -DHAVE_VISIBILITY_ATTRIBUTE=1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -DHAVE__UNWIND_BACKTRACE=1 -DHAVE___CXA_DEMANGLE=1 -DJS_CODEGEN_X64=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DJS_PUNBOX64=1 -DMALLOC_H='<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR='' -DMOZILLA_OFFICIAL=1 -DMOZILLA_UAVERSION='"60.0"' -DMOZILLA_VERSION='"60.0"' -DMOZILLA_VERSION_U=60.0 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZ_ADDON_SIGNING=1 -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"60.0"' -DMOZ_BUILD_APP=browser -DMOZ_BUNDLED_FONTS=1 -DMOZ_CONTENT_SANDBOX=1 -DMOZ_CRASHREPORTER=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_DLL_SUFFIX='".so"' -DMOZ_ENABLE_DBUS=1 -DMOZ_ENABLE_GCONF=1 -DMOZ_ENABLE_SIGNMAR=1 -DMOZ_ENABLE_SKIA=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_FEEDS=1 -DMOZ_FFMPEG=1 -DMOZ_FFVPX=1 -DMOZ_FMP4=1 -DMOZ_GECKO_PROFILER=1 -DMOZ_GLUE_IN_PROGRAM=1 -DMOZ_GMP_SANDBOX=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_LIBAV_FFT=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.firefox -DMOZ_MEMORY=1 -DMOZ_OFFICIAL_BRANDING=1 -DMOZ_OLD_STYLE=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PHOENIX=1 -DMOZ_PLACES=1 -DMOZ_PULSEAUDIO=1 -DMOZ_RAW=1 -DMOZ_REQUIRE_SIGNING=1 -DMOZ_RUST_SIMD=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_SANDBOX=1 -DMOZ_SCTP=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_STYLO=1 -DMOZ_STYLO_ENABLE=1 -DMOZ_TELEMETRY_REPORTING=1 -DMOZ_TREE_CAIRO=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=beta -DMOZ_USER_DIR='".mozilla"' -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_VORBIS=1 -DMOZ_VPX_NO_MEM_REPORTING=1 -DMOZ_WEBM_ENCODER=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WIDGET_GTK=3 -DMOZ_X11=1 -DMOZ_XUL=1 -DNO_NSPR_10_SUPPORT=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DRELEASE_OR_BETA=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTARGET_XPCOM_ABI='"x86_64-gcc3"' -DUSE_SKIA=1 -DUSE_SKIA_GPU=1 -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DVA_COPY=va_copy -DVPX_X86_ASM=1 -DXP_LINUX=1 -DXP_UNIX=1 -D_REENTRANT=1 -DAB_CD=en-US '/builds/worker/workspace/build/src/browser/branding/official/pref/firefox-branding.js' -o '../../../dist/bin/browser/defaults/preferences/firefox-branding.js'
[task 2018-02-20T15:59:44.293Z] 15:59:44     INFO -  Traceback (most recent call last):
[task 2018-02-20T15:59:44.293Z] 15:59:44     INFO -    File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -      "__main__", fname, loader, pkg_name)
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -    File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -      exec code in run_globals
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/preprocessor.py", line 24, in <module>
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -      main(sys.argv[1:])
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/preprocessor.py", line 20, in main
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -      pp.handleCommandLine(args, True)
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 480, in handleCommandLine
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -      self.processFile(input=input, output=out)
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 387, in processFile
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -      self.failUnused(input.name)
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/preprocessor.py", line 332, in failUnused
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -      raise Preprocessor.Error(fake, msg, None)
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -  mozbuild.preprocessor.Error: ('/builds/worker/workspace/build/src/browser/branding/official/pref/firefox-branding.js', None, 'no preprocessor directives found', None)
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1477: recipe for target '../../../dist/bin/browser/defaults/preferences/firefox-branding.js' failed
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -  make[5]: *** [../../../dist/bin/browser/defaults/preferences/firefox-branding.js] Error 1
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/branding/official'
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:100: recipe for target 'browser/branding/official/misc' failed
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -  make[4]: *** [browser/branding/official/misc] Error 2
[task 2018-02-20T15:59:44.294Z] 15:59:44     INFO -  make[4]: *** Waiting for unfinished jobs....

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Shouldn't this try push contain something like the following, too?

ac_add_options --enable-official-branding
ac_add_options --enable-update-channel=beta

I've tested my patch with the above and the test passed.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry, the backout of bug 1432310 which kept the beta simulations building after bug 1432310 landed was still in the simulation patch stack. Will verify it as fixed with the next beta uplift simulation later today or tomorrow.

FYI, the parent changeset https://hg.mozilla.org/try/rev/787719f4369f sets the
> ac_add_options --enable-official-branding

Not sure where the update channel gets set, RyanVM would know.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

branch_specifics.py sets that:
https://hg.mozilla.org/try/diff/795756d58273/testing/mozharness/configs/builds/branch_specifics.py

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Also, the raw log from Aryx' linked run in #c0 pretty clearly shows the update channel as being set to Beta.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

New Try push doesn't have the issue: https://treeherder.mozilla.org/#/jobs?repo=try&revision=893a92ec8f13d36f07aad39319132e437319df76

Comment 6

[Intermittent Failures Robot]

22 failures in 675 pushes (0.033 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 22

Platform breakdown:
* linux64: 6
* windows2012-64: 4
* windows2012-32: 4
* osx-cross: 4
* linux32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1439640&startday=2018-02-19&endday=2018-02-25&tree=all