Closed
Bug 1439663
Opened 6 years ago
Closed 6 years ago
Delete ancient string declarations in jsnum.h
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
js_isNaN_str and friends are now declared in JSAtom.h. There's no need for the redundant declarations in jsnum.h
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8952429 -
Flags: review?(jdemooij)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8952429 [details] [diff] [review] Remove declarations that are redundant with vm/JSAtom.h Review of attachment 8952429 [details] [diff] [review]: ----------------------------------------------------------------- Nice
Attachment #8952429 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/396b5879a7ea49e0f32f677a4f2bc3584108b5b9 Bug 1439663 - Remove declarations that are redundant with vm/JSAtom.h. r=jandem.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/396b5879a7ea
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•