Closed Bug 1439665 Opened 2 years ago Closed 2 years ago

Remove jscpucfg.h

Categories

(Core :: JavaScript Engine, enhancement, P5, trivial)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(2 files)

The sole feature remaining in this header, JS_STACK_GROWTH_DIRECTION, can be moved to jsfriendapi.h (its main customer).
"Include what you use."
Attachment #8952435 - Flags: review?(sphink)
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Attachment #8952437 - Flags: review?(sphink)
Comment on attachment 8952435 [details] [diff] [review]
Part 1: #include some headers directly in files that use them

Review of attachment 8952435 [details] [diff] [review]:
-----------------------------------------------------------------

Seems believable.
Attachment #8952435 - Flags: review?(sphink) → review+
Comment on attachment 8952437 [details] [diff] [review]
Part 2: Remove jscpucfg.h

Review of attachment 8952437 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8952437 - Flags: review?(sphink) → review+
(In reply to Jason Orendorff [:jorendorff] from comment #0)
> The sole feature remaining in this header, JS_STACK_GROWTH_DIRECTION, can be
> moved to jsfriendapi.h (its main customer).

Can't it be removed altogether?  I'm reasonably sure I had an exchange with jandem about this not too long ago and the conclusion was that we depend on the stack growing downward in memory in all sorts of places.
I would be OK with deleting it too. Feel free! Going to land this anyway, as it's preliminary to other stuff.
Severity: normal → trivial
Priority: -- → P5
https://hg.mozilla.org/mozilla-central/rev/d94bdb98167c
https://hg.mozilla.org/mozilla-central/rev/976ffd186f5b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.