Closed Bug 1439682 Opened 3 years ago Closed 3 years ago

IpcResourceUpdateQueue can result in corruption upon a large chunk alloc failure

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/0c0ddaa7e859a2b76a56a0e2e9c0de88af166812/gfx/layers/wr/IpcResourceUpdateQueue.cpp#39

The return value is not checked to see if the alloc passed. If it failed, we're just going to go ahead and write the new data into the most-recently allocated large chunk, clobbering whatever data was there. Who knows what this will do.
Comment on attachment 8952502 [details]
Bug 1439682 - Guard against large chunk allocation failure.

https://reviewboard.mozilla.org/r/221712/#review228562
Attachment #8952502 - Flags: review?(nical.bugzilla) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5309823830e6
Guard against large chunk allocation failure. r=nical
https://hg.mozilla.org/mozilla-central/rev/5309823830e6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.