Closed Bug 1439716 Opened 8 years ago Closed 8 years ago

Update UIConstants.swift to refer to auto-generated Photon colors.

Categories

(Firefox for iOS :: Theme & Visual Design, enhancement, P3)

Product:
Firefox for iOS
Component:
Theme & Visual Design
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 12.0 ---

People

(Reporter: bwinton, Unassigned)

Details

There's a whole new swift file being added as part of https://github.com/FirefoxUX/design-tokens/pull/43 that defines the Photon palette. We should copy it into the iOS source tree, and change https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/UIConstants.swift#L31 to refer to it, I think. :) We should probably do this in two parts: 1) Just add the new file, and update the existing one to use it. 2) After that's done, see if there are any colours that are close to Photon colours and talk about swapping them out for the more-official ones.
tracking-fxios: ? → 11.0
Priority: -- → P3
As a side note, the file has been officially released in the npm package at https://www.npmjs.com/package/photon-colors
Landed in master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.