1439732 - backout bug 1415991 (removed signed unpacked add-on support)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

This bug will track backing out bug 1415991.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbd7da7ccbbf2da230119ca776616547f0f2a89

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: backout patch

This is just `hg backout 0a5795108e0a`.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: fixup for 60

This is a fixup for 60 only due to bug 1421084.

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8952555 [details] [diff] [review]
fixup for 60

Review of attachment 8952555 [details] [diff] [review]:
-----------------------------------------------------------------

Yup.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Shouldn't we also back this out from 59?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4560309df57b
fixup for backing out bug 1415991 post bug 1421084 (so Firefox 60 only) r=jcj

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Yes - once this lands on central I'll ask for beta uplift for just the backout patch (unless we need to move faster than that and I'll ask for uplift sooner).

Comment 7

[Natalia Csoregi [:nataliaCs]]

Revision on m-c https://hg.mozilla.org/mozilla-central/rev/4560309df57b52d4946e309d12c150ddef61ef66

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8952554 [details] [diff] [review]
backout patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1415991 (removing support for verifying signatures on signed unpacked add-ons)
[User impact if declined]: signed unpacked add-ons will break for users before we've had a chance to deprecate them properly
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not very
[Why is the change risky/not risky?]: this is a straight-forward backout. It just returns the code to where it was before bug 1415991 landed (and on 59, nothing else seems to have affected the behavior of that code, so we don't even need to make additional changes to make that work)
[String changes made/needed]: none

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8952554 [details] [diff] [review]
backout patch

Backing this out from beta as discussed over email. This should land for tomorrow's beta 12 build.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/293cb8267530