Closed Bug 1439741 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 9591 - ReadableStream: Add tests for shutting down when readable becomes errored with preventAbort = true

Categories

(Testing :: web-platform-tests, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 9591 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9591
Details from upstream follow.

Mattias Buelens wrote:
>  ReadableStream: Add tests for shutting down when readable becomes errored with preventAbort = true
>  
>  After looking at the new tests introduced in #5636 and #9573, I found that there was a small mismatch between the tests for forward close propagation and forward error propagation.
>  
>  For closing, we have 4 tests for the shutdown behavior:
>  1. Closing must be propagated forward: shutdown must not occur until the final write completes
>  2. Closing must be propagated forward: shutdown must not occur until the final write completes; preventClose = true
>  3. Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write
>  4. Closing must be propagated forward: shutdown must not occur until the final write completes; becomes closed after first write; preventClose = true
>  
>  For erroring, we only have 2:
>  1. Errors must be propagated forward: shutdown must not occur until the final write completes
>  2. Errors must be propagated forward: abort should not happen until all queued writes complete
>  
>  This PR reworks the forward error propagation tests, so we now have similar variants:
>  1. Errors must be propagated forward: shutdown must not occur until the final write completes
>  2. Errors must be propagated forward: shutdown must not occur until the final write completes; preventAbort = true
>  3. Errors must be propagated forward: shutdown must not occur until the final write completes; becomes errored after first write
>  4. Errors must be propagated forward: shutdown must not occur until the final write completes; becomes errored after first write; preventAbort = true
>
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15a33e49b5ea
[wpt PR 9591] - ReadableStream: Add tests for shutting down when readable becomes errored with preventAbort = true, a=testonly
https://hg.mozilla.org/mozilla-central/rev/15a33e49b5ea
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.