Closed
Bug 1439770
Opened 6 years ago
Closed 6 years ago
Inline constant argument to InterfaceDescriptorAddTypes
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(2 files)
This method's third argument is an integer, but there's a single caller that only passes in 1, so just inline that argument. Incidentally, this exposed a minor integer overflow bug, because the compiler was able to understand the simplified code enough to give a warning.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•6 years ago
|
||
Here's the commit message for part 1: num_additional_types is a uint8_t, so its max value is 255. 1 + 255 is not greater than 256, so the check will pass, but then num_additional_types += 1 will overflow in the next line. What I think happened is that bug 1249174 part 6 introduced a bounds check on an index (which is ok), but then part 8 repurposed this as a bounds check on the length. I noticed this because while writing the next patch I ended up with if (id->num_additional_types > 255) and then the compiler warned that the check would never fail.
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8952564 [details] Bug 1439770, part 1 - Fix integer overflow in InterfaceDescriptorAddTypes. https://reviewboard.mozilla.org/r/221810/#review227706
Attachment #8952564 -
Flags: review?(n.nethercote) → review+
|
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8952565 [details] Bug 1439770, part 2 - Inline constant argument to InterfaceDescriptorAddTypes. https://reviewboard.mozilla.org/r/221812/#review227708
Attachment #8952565 -
Flags: review?(n.nethercote) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/486abdc9fc6a part 1 - Fix integer overflow in InterfaceDescriptorAddTypes. r=njn https://hg.mozilla.org/integration/autoland/rev/51341e7c00c5 part 2 - Inline constant argument to InterfaceDescriptorAddTypes. r=njn
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/486abdc9fc6a https://hg.mozilla.org/mozilla-central/rev/51341e7c00c5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•