Closed Bug 1439807 Opened 4 years ago Closed 4 years ago

Extend displaylist_mutate to also test inactive layers

Categories

(Testing :: Talos, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

The displaylist_mutate test is really useful, but it only tests a single item type, and takes a pretty ideal path through FrameLayerBuilder.

I want to add a few more subtests that add coverage for some of the more complex (but still frequent) paths.

This new test is basically identical, but transforms every <div> by a single pixel. It also has 1/10th of the number of elements, so that the results are somewhat similar in magnitude (though it looks like we're still 2x worse on OSX).
Attachment #8952603 - Flags: review?(jmaher)
Comment on attachment 8952603 [details] [diff] [review]
talos-test-inactive

Review of attachment 8952603 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/talos/talos/tests/layout/benchmarks/displaylist_inactive_mutate.html
@@ +39,5 @@
> +      window.tpRecordTime(end - start, start);
> +    }
> +    if (parent.reportResults) {
> +      parent.reportResults(end - start, start);
> +    }

I know this is code which is almost identical to the existing displaylist_mutate.html, but what is parent.reportResults for?
Attachment #8952603 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #1)
 
> I know this is code which is almost identical to the existing
> displaylist_mutate.html, but what is parent.reportResults for?

I have no idea! I just copied this from the existing test. Want me to remove it?
sure- possibly from the other test file as well- I couldn't find a parent.reportResults- if this comes from another framework I don't mind leaving it in.
See Also: → 1440177
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2925f1f589ea
Extend displaylist_mutate to also test inactive layers. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/2925f1f589ea
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
See Also: → 1473899
You need to log in before you can comment on or make changes to this bug.