1439807 - Extend displaylist_mutate to also test inactive layers

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: talos-test-inactive

The displaylist_mutate test is really useful, but it only tests a single item type, and takes a pretty ideal path through FrameLayerBuilder.

I want to add a few more subtests that add coverage for some of the more complex (but still frequent) paths.

This new test is basically identical, but transforms every <div> by a single pixel. It also has 1/10th of the number of elements, so that the results are somewhat similar in magnitude (though it looks like we're still 2x worse on OSX).

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8952603 [details] [diff] [review]
talos-test-inactive

Review of attachment 8952603 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/talos/talos/tests/layout/benchmarks/displaylist_inactive_mutate.html
@@ +39,5 @@
> +      window.tpRecordTime(end - start, start);
> +    }
> +    if (parent.reportResults) {
> +      parent.reportResults(end - start, start);
> +    }

I know this is code which is almost identical to the existing displaylist_mutate.html, but what is parent.reportResults for?

Comment 2

[Matt Woodrow (:mattwoodrow)]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #1)
 
> I know this is code which is almost identical to the existing
> displaylist_mutate.html, but what is parent.reportResults for?

I have no idea! I just copied this from the existing test. Want me to remove it?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

sure- possibly from the other test file as well- I couldn't find a parent.reportResults- if this comes from another framework I don't mind leaving it in.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2925f1f589ea
Extend displaylist_mutate to also test inactive layers. r=jmaher

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2925f1f589ea