Closed Bug 1439828 Opened 6 years ago Closed 6 years ago

gfx/tests/gtest/TestTreeTraversal.cpp - name collision between Solaris queue(9F) and C++ std::queue

Categories

(Firefox :: Untriaged, defect)

Product:
Firefox
Component:
Untriaged
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: petr.sumbera, Assigned: petr.sumbera)

Details

Attachments

(1 file)

Bug1439828.patch
1.06 KB, patch
botond
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180206200532

Steps to reproduce:

101:11.18 /usr/bin/g++ -std=gnu++14 -o Unified_cpp_gfx_tests_gtest1.o -c -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/stl_wrappers -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/system_wrappers -include /scratch/firefox/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_SOLARIS=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/scratch/firefox/gfx/tests/gtest -I/scratch/firefox/obj-x86_64-pc-solaris2.11/gfx/tests/gtest -I/scratch/firefox/obj-x86_64-pc-solaris2.11/ipc/ipdl/_ipdlheaders -I/scratch/firefox/ipc/chromium/src -I/scratch/firefox/ipc/glue -I/scratch/firefox/gfx/2d -I/scratch/firefox/gfx/2d/unittest -I/scratch/firefox/gfx/config -I/scratch/firefox/gfx/layers -I/scratch/firefox/gfx/ots/src -I/scratch/firefox/gfx/qcms -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nspr -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /scratch/firefox/obj-x86_64-pc-solaris2.11/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -O -fno-omit-frame-pointer -I/scratch/firefox/obj-x86_64-pc-solaris2.11/dist/include/cairo -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_gfx_tests_gtest1.o.pp   /scratch/firefox/obj-x86_64-pc-solaris2.11/gfx/tests/gtest/Unified_cpp_gfx_tests_gtest1.cpp
101:28.73 In file included from /scratch/firefox/obj-x86_64-pc-solaris2.11/gfx/tests/gtest/Unified_cpp_gfx_tests_gtest1.cpp:92:0:
101:28.73 /scratch/firefox/gfx/tests/gtest/TestTreeTraversal.cpp: In function 'RefPtr<T> BreadthFirstSearchForwardQueue(RefPtr<T>)':
101:28.73 /scratch/firefox/gfx/tests/gtest/TestTreeTraversal.cpp:1388:3: error: reference to 'queue' is ambiguous
101:28.73    queue<RefPtr<Node>> nodes;
101:28.73    ^

This is similar issue to: https://bugzilla.mozilla.org/show_bug.cgi?id=1368093
Attached patch Bug1439828.patch — — Splinter Review 

        Attachment #8952636 -
        Flags: review?(botond)

    
    

    
  
Comment on attachment 8952636 [details] [diff] [review]
Bug1439828.patch

Review of attachment 8952636 [details] [diff] [review]:
-----------------------------------------------------------------

I'm surprised we didn't have a "using std::queue" or "using namespace std" in this file. I guess, thanks to unified builds, a "using namespace std" from another test file was in scope.

        Attachment #8952636 -
        Flags: review?(botond) → review+

    
  
Keywords: checkin-needed
Assignee: nobody → petr.sumbera

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c41bd6711b5
Name collision between Solaris queue(9F) and C++ std::queue. r=botond
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5c41bd6711b5
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago

          status-firefox60:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: