1439840 - Activity Streams search bar is displayed behind the Tour notification

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Resize.gif

[Affected versions]:
60.0a1 (BuildId:20180220220044)

[Unaffected versions]:
59.0b11 (BuildId:20180219114835)
58.0.2 (BuildId:20180206200532)
52.6.0 esr (BuildId:20180118122319)

[Affected platforms]:
Windows 10 64bit.
macOS 10.13.
Ubuntu 16.04 64bit.

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Access the about:newtab page.
3. Resize the Firefox window.	

[Expected result]:
The window is successfully resized and all the page elements are properly displayed.

[Actual result]:
The Search Bar is displayed under the Firefox tour notification.
It seems that the notification is not dismissed even if the user starts typing inside the search bar. 

The notification gets dismissed if further shrinking the Firefox window.


[Regression range]:
This is a regression:

Last good revision: fe8269ac41f5a40fd1e5a2e06ae193bc9462438c
First bad revision: 22f78ddb57200a9d8b4577629cc24ef7c51d4ed5

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fe8269ac41f5a40fd1e5a2e06ae193bc9462438c&tochange=22f78ddb57200a9d8b4577629cc24ef7c51d4ed5

[Note]
For further information regarding this issue please observe the attached screencast.

Comment 1

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

This affects the Onboarding overlay feature, can anyone from you guys take a peek at this?

Comment 2

[chsiang]

Hi Cristian, Evan is no longer with Mozilla. 

Chris, do you know any engineers who are taking onboarding work and can take a look at this?

Comment 4

[Tim Spurway [:tspurway]]

we can take this one, :chsiang

Comment 6

[Ed Lee :Mardak]

uifeedback: Adjust the onboarding "show as dot instead of message" threshold so that it only auto-expands if it would not overlap with the search box (for both narrow and wide layouts -- [ed] although I believe activity stream is responsive enough that it will happen to switch to wide layout before there's enough space to show onboarding message in narrow view)

Wontfix for 62 but we'll want this in for 63.

Comment 7

[Ed Lee :Mardak]

Attachment: 1365px min width

I shared this picture with bryan: "Then it flips to a dot [when 1px narrower]? Sure"

Comment 8

[Ed Lee :Mardak]

Attachment: Bug 1439840 - Activity Streams search bar is displayed behind the Tour notification.

Increase the min width now that activity stream responsively switches to a wide layout (which increases the width of the search box).

Review commit: https://reviewboard.mozilla.org/r/255534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255534/

Comment 9

[Kate Hudson :k88hudson]

Comment on attachment 8990462 [details]
Bug 1439840 - Activity Streams search bar is displayed behind the Tour notification.

https://reviewboard.mozilla.org/r/255534/#review262552

This works as expected, R+ to be as long as we are aware of the possible impact of the speech bubble showing up for less users (if screen sizes are smaller than the threshold)

Comment 10

[Ed Lee :Mardak]

(In reply to Kate Hudson :k88hudson from comment #9)
> if screen sizes are smaller than the threshold
Nod. And this will impact the default profile new window behavior. Aaron confirmed that the long term plan is to just get rid of this bubble message as it was a temporary solution to help drive people to the onboarding modal.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a354f4c70b1
Activity Streams search bar is displayed behind the Tour notification. r=k88hudson

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2a354f4c70b1

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the issue is no longer reproducible on Windows 10 x64, Arch Linux and Mac 10.13, with the latest Nightly build (63.0a1 Build ID - 20180724100052) installed. Now the "Tour Notification" no longer overlaps the "Search Bar".