Closed Bug 1439841 Opened 6 years ago Closed 6 years ago

Update favicons for the default bookmarks

Categories

(Firefox :: Bookmarks & History, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

Looking at the default bookmarks in bookmarks.html.in, there's a few icons that are now out of date:

- The mozilla_icon is based on the old logo (I think), and we now have a new favicon on the website.

https://www.mozilla.org/media/img/favicon/favicon-196x196.c80e6abe0767.png

- The support pages ("Help and Tutorials", "Customise Firefox") are now using the Firefox icon rather than the mozilla_icon.
- The firefox_icon in the file is also the older version of the logo.

https://support.cdn.mozilla.net/static/sumo/img/favicon-32x32.png
https://support.cdn.mozilla.net/static/sumo/img/favicon-16x16.png
Marco, is there a recommended size of icon we should be shipping in bookmarks.html?
Flags: needinfo?(mak77)
We didn't define one. I think 32px will work in most cases. For Activity Stream we may want larger icons, but those would also add weight to the install and that may not be worth it.
Flags: needinfo?(mak77)
Stephen, do you have a 32px by 32px "M" logo that we could use, or do you know who we could ask?

The one on the Mozilla website is a little larger than we'd like.
Flags: needinfo?(shorlander)
Can it be SVG? Or does it have to be an .ico?
Flags: needinfo?(shorlander) → needinfo?(standard8)
(In reply to Stephen Horlander [:shorlander] from comment #4)
> Can it be SVG? Or does it have to be an .ico?

An svg or png would be just fine (either will work), although svgs may be slightly bigger in this case.
Flags: needinfo?(standard8) → needinfo?(shorlander)
Attached image favicon-mozilla-16.svg
Flags: needinfo?(shorlander)
Comment on attachment 8954312 [details]
Bug 1439841 - Update favicons for the default bookmarks.

https://reviewboard.mozilla.org/r/223432/#review229542
Attachment #8954312 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/765bfffce2b4
Update favicons for the default bookmarks. r=mak
https://hg.mozilla.org/mozilla-central/rev/765bfffce2b4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
QA Whiteboard: [good first verify]
This feature request is implemented on Latest Firefox Beta---
Build ID 	20180419200216
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

tested os-- windows7 4bit

[testday-20180420]
You need to log in before you can comment on or make changes to this bug.