Update favicons for the default bookmarks

RESOLVED FIXED in Firefox 60

Status

()

P2
normal
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Firefox 60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(2 attachments)

(Assignee)

Description

9 months ago
Looking at the default bookmarks in bookmarks.html.in, there's a few icons that are now out of date:

- The mozilla_icon is based on the old logo (I think), and we now have a new favicon on the website.

https://www.mozilla.org/media/img/favicon/favicon-196x196.c80e6abe0767.png

- The support pages ("Help and Tutorials", "Customise Firefox") are now using the Firefox icon rather than the mozilla_icon.
- The firefox_icon in the file is also the older version of the logo.

https://support.cdn.mozilla.net/static/sumo/img/favicon-32x32.png
https://support.cdn.mozilla.net/static/sumo/img/favicon-16x16.png
(Assignee)

Comment 1

9 months ago
Marco, is there a recommended size of icon we should be shipping in bookmarks.html?
Flags: needinfo?(mak77)

Comment 2

9 months ago
We didn't define one. I think 32px will work in most cases. For Activity Stream we may want larger icons, but those would also add weight to the install and that may not be worth it.
Flags: needinfo?(mak77)
(Assignee)

Comment 3

9 months ago
Stephen, do you have a 32px by 32px "M" logo that we could use, or do you know who we could ask?

The one on the Mozilla website is a little larger than we'd like.
Flags: needinfo?(shorlander)
Can it be SVG? Or does it have to be an .ico?
Flags: needinfo?(shorlander) → needinfo?(standard8)
(Assignee)

Comment 5

9 months ago
(In reply to Stephen Horlander [:shorlander] from comment #4)
> Can it be SVG? Or does it have to be an .ico?

An svg or png would be just fine (either will work), although svgs may be slightly bigger in this case.
Flags: needinfo?(standard8) → needinfo?(shorlander)
Created attachment 8953634 [details]
favicon-mozilla-16.svg
Flags: needinfo?(shorlander)
Comment hidden (mozreview-request)

Comment 8

9 months ago
mozreview-review
Comment on attachment 8954312 [details]
Bug 1439841 - Update favicons for the default bookmarks.

https://reviewboard.mozilla.org/r/223432/#review229542
Attachment #8954312 - Flags: review?(mak77) → review+

Comment 9

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/765bfffce2b4
Update favicons for the default bookmarks. r=mak

Comment 10

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/765bfffce2b4
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
QA Whiteboard: [good first verify]
This feature request is implemented on Latest Firefox Beta---
Build ID 	20180419200216
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

tested os-- windows7 4bit

[testday-20180420]
You need to log in before you can comment on or make changes to this bug.