Closed
Bug 1439883
Opened 6 years ago
Closed 6 years ago
Port |Bug 1435671 - Reduce binary size by making NS_MutateURI.Apply not be a templated method| - nsMsgSend.cpp(2059): error C2275: 'nsIURLMutator': illegal use of this type as an expression
Categories
(MailNews Core :: Backend, enhancement)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 60.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(2 files)
1.40 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
1.27 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
mailnews/compose/src/nsMsgSend.cpp(2059): error C2275: 'nsIURLMutator': illegal use of this type as an expression mailnews/compose/src/nsMsgSend.cpp 2059 .Apply<nsIURLMutator>(&nsIURLMutator::SetFileName, Only use in C-C here, I'll fix it this afternoon.
Assignee | ||
Comment 1•6 years ago
|
||
Compiling with this now.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/30d95f2b12ff Port Bug 1435671: NS_MutateURI::Apply() is no longer templated. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 60.0
Version: 52 → Trunk
Comment on attachment 8952693 [details] [diff] [review] 1439883-apply.patch Review of attachment 8952693 [details] [diff] [review]: ----------------------------------------------------------------- The syntax of this thing is getting crazier every day.
Attachment #8952693 -
Flags: review+
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8952709 [details] [diff] [review] 1439883-apply.patch - one more in LDAP Review of attachment 8952709 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. ::: ldap/xpcom/src/nsLDAPURL.cpp @@ +42,2 @@ > nsIStandardURL::URLTYPE_STANDARD, > aDefaultPort, PromiseFlatCString(aSpec), Do you intentionally not fix the indentation? Or is the bugzilla view of the patch misleading me?
Attachment #8952709 -
Flags: review+
Assignee | ||
Comment 6•6 years ago
|
||
Thanks, fixed the indentation in nsMsgSend.cpp as well.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/d2ebf88f37f1 Port Bug 1435671: NS_MutateURI::Apply() is no longer templated (take 2). r=aceman
You need to log in
before you can comment on or make changes to this bug.
Description
•