1439897 - [Accessibility] The toolbar container should have a role of "toolbar" and a localized label for screen readers.

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Marco Zehe (:MarcoZ)]

STR:
1. Start NVDA and Firefox on Windows.
2. Load any page, e. g. https://www.mozilla.org.
3. Press CTRL+Shift+K to open teh console.
4. Shift-tab several times until keyboard focus lands in the main tool bar.

Expected: NVDA should say something like "Main toolbar", followed by the button that currently has focus.
Actual: NVDA will speak the button, but not the fact that we're now in the main tool bar.

To resolve:
1. Give the div with ID toolbox-toolbar-mount a role of "toolbar".
2. Give it a localizable name like "Main", "Toolbox", or reuse the string that the xul:window parent element is already getting.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1439897 - Give the toolbox toolbar a proper role and label for accessibility,

Review commit: https://reviewboard.mozilla.org/r/222958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222958/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8953729 [details]
Bug 1439897 - Give the toolbox toolbar a proper role and label for accessibility,

https://reviewboard.mozilla.org/r/222958/#review229392

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b82ea31ddb2d
Give the toolbox toolbar a proper role and label for accessibility, r=bgrins

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b82ea31ddb2d

Comment 5

[Tom Bannister]

Was able to reproduce this bug on Firefox 59.0.3 (64-bit), Build ID = 20180427210249 on Windows 10 64 bit.

Bug is no longer reproducible on Firefox Nightly 60.0b16 (64-bit, Build ID = 20180426170554 on Windows 10 64 bit.

[testday-20180420]