Linker::newCode takes AllowGC parameter but never triggers GC

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: jonco, Assigned: jonco)

Tracking

({spring-cleaning})

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Despite taking an AllowGC template paramter, Linker::newCode can never GC because it suppresses it as the first thing it does:

https://searchfox.org/mozilla-central/source/js/src/jit/Linker.cpp#22

This is confusing.  The template parameter should be removed.
Keywords: spring-cleaning
Priority: -- → P3
Patch to remove the template parameter from Linker::newCode().
Attachment #8952758 - Flags: review?(nicolas.b.pierron)
Attachment #8952758 - Flags: review?(nicolas.b.pierron) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46dd3f988d67
Simplify Linker::newCode to remove unnecessary AllowGC parameter r=nbp
https://hg.mozilla.org/mozilla-central/rev/46dd3f988d67
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.