Closed Bug 1439908 Opened 4 years ago Closed 4 years ago

Linker::newCode takes AllowGC parameter but never triggers GC

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

(Keywords: spring-cleaning)

Attachments

(1 file)

Despite taking an AllowGC template paramter, Linker::newCode can never GC because it suppresses it as the first thing it does:

https://searchfox.org/mozilla-central/source/js/src/jit/Linker.cpp#22

This is confusing.  The template parameter should be removed.
Keywords: spring-cleaning
Priority: -- → P3
Patch to remove the template parameter from Linker::newCode().
Attachment #8952758 - Flags: review?(nicolas.b.pierron)
Attachment #8952758 - Flags: review?(nicolas.b.pierron) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46dd3f988d67
Simplify Linker::newCode to remove unnecessary AllowGC parameter r=nbp
https://hg.mozilla.org/mozilla-central/rev/46dd3f988d67
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.