Closed Bug 1439911 Opened 3 years ago Closed 3 years ago

webrender: ~instant crash watching any video

Categories

(Core :: Graphics: WebRender, defect, P1)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox-esr52 --- unaffected
firefox58 --- disabled
firefox59 --- disabled
firefox60 --- fixed

People

(Reporter: Gankra, Assigned: kvark)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

This bug was filed from the Socorro interface and is
report bp-e549f0f4-f681-4b40-8bba-2b9850180221.
=============================================================

Top 10 frames of crashing thread:

0 XUL CrashStatsLogForwarder::CrashAction gfx/thebes/gfxPlatform.cpp:409
1 XUL mozilla::gfx::Log<1, mozilla::gfx::CriticalLogger>::Flush gfx/2d/Logging.h:732
2 XUL mozilla::layers::CompositorManagerChild::ProcessingError gfx/2d/Logging.h:276
3 XUL mozilla::ipc::MessageChannel::MaybeHandleError ipc/glue/MessageChannel.cpp:2513
4 XUL mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2040
5 XUL mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1919
6 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1040
7 XUL NS_ProcessPendingEvents xpcom/threads/nsThreadUtils.cpp:459
8 XUL nsBaseAppShell::NativeEventCallback widget/nsBaseAppShell.cpp:98
9 XUL nsAppShell::ProcessGeckoEvents widget/cocoa/nsAppShell.mm:436

=============================================================
So far this morning I have seen this when trying to open a video on youtube and when trying to play a "gif" (video) on twitter.
Summary: webrender: ~instant crash going to any youtube video page → webrender: ~instant crash watching any video
Blocks: wr-stability
I ran this on a local debug build and got this:

ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)

 Failed to render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n"))
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: wr_renderer_render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n")) (t=44.2749) [GFX1-]: wr_renderer_render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n"))
Failed to compile shader: brush_yuv_image
ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)

 Failed to render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n"))
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: wr_renderer_render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n")) (t=44.2749) |[1][GFX1-]: wr_renderer_render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n")) (t=44.3119) [GFX1-]: wr_renderer_render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n"))
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: wr_renderer_render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n")) (t=44.2749) |[1][GFX1-]: wr_renderer_render: Shader(Compilation("brush_yuv_image", "ERROR: 0:88: No matching function for call to textureSize(sampler2DRect, int)\n")) (t=44.3119) |[2][GFX1-]: Compositors might be mixed (5,2) (t=44.3951) [GFX1-]: Compositors might be mixed (5,2)
Dzmitry, do you know what's going on here? The build has your last fix to this shader from #2437.
Flags: needinfo?(kvark)
Assignee: nobody → kvark
Status: NEW → ASSIGNED
Flags: needinfo?(kvark)
Another missed case for shader permutations, will be fixed in https://github.com/servo/webrender/pull/2452
:Gankro, can this bug be closed?
Flags: needinfo?(a.beingessner)
Seems like it. (FYI Gankro is on leave)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(a.beingessner)
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.