1439931 - extractScheme should lowercase its output

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[:Gijs (he/him)]

When using the IO service to construct a URI, the scheme is always lowercase, even if it isn't in the input.

The same should probably be true when using extractScheme to get just the scheme in the would-be URL.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1439931 - nsIIOService.extractScheme/net_ExtractURLScheme should lowercase its output

Review commit: https://reviewboard.mozilla.org/r/221982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221982/

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

btw, the output of net_ExtractURLScheme is still compared with lowercased schemes in various code points, this is just one.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

You're right. Maybe I should do the lowercasing in net_ExtractURLScheme then?

Comment 4

[Anne (:annevk)]

Yes and you'll need to verify all callers.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8952745 [details]
Bug 1439931 - nsIIOService.extractScheme/net_ExtractURLScheme should lowercase its output

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221982/diff/1-2/

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 8952745 [details]
Bug 1439931 - nsIIOService.extractScheme/net_ExtractURLScheme should lowercase its output

https://reviewboard.mozilla.org/r/221982/#review229102

r- only for the missing test file or explanation of the ini file change.

you can probably remove toLowerCase/LowerCaseEqualsLiteral now at:

https://searchfox.org/mozilla-central/rev/b469db5c90d618f4b202d5ef280e1a78224eb43b/browser/base/content/browser.js#6079
https://searchfox.org/mozilla-central/rev/b469db5c90d618f4b202d5ef280e1a78224eb43b/docshell/base/nsDefaultURIFixup.cpp#165
https://searchfox.org/mozilla-central/rev/b469db5c90d618f4b202d5ef280e1a78224eb43b/docshell/base/nsDefaultURIFixup.cpp#235-280
https://searchfox.org/mozilla-central/rev/b469db5c90d618f4b202d5ef280e1a78224eb43b/docshell/base/nsDefaultURIFixup.cpp#180
https://searchfox.org/mozilla-central/rev/b469db5c90d618f4b202d5ef280e1a78224eb43b/netwerk/protocol/viewsource/nsViewSourceChannel.cpp#60
https://searchfox.org/mozilla-central/rev/b469db5c90d618f4b202d5ef280e1a78224eb43b/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1683

::: netwerk/test/unit/xpcshell.ini:418
(Diff revision 2)
>  [test_bug1411316_http1.js]
>  [test_header_Server_Timing.js]
>  [test_trr.js]
>  # http2-using tests require node available
>  skip-if = os == "android"
> +[test_ioservice.js]

what's this change? missing the test file in the patch?

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8952745 [details]
Bug 1439931 - nsIIOService.extractScheme/net_ExtractURLScheme should lowercase its output

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221982/diff/2-3/

Comment 8

[Honza Bambas (:mayhemer)]

Comment on attachment 8952745 [details]
Bug 1439931 - nsIIOService.extractScheme/net_ExtractURLScheme should lowercase its output

https://reviewboard.mozilla.org/r/221982/#review229124

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94346696a773
nsIIOService.extractScheme/net_ExtractURLScheme should lowercase its output r=mayhemer

Comment 10

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/94346696a773