1439947 - [Regression] URLBar buttons need safeArea insets on the iPhone X

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: Screen Shot 2018-02-21 at 17.08.41.png

Device: iPhone X
Build: 11.0(9148)
iOS: 11.1

Steps to reproduce:
1. Launch Firefox
2. Switch the view to landscape
3. Open Tabs Tray
4. Open a New Tab 

or 

1. Launch Firefox
2. Switch the view to landscape
3. Open Tabs Tray
4. Tap on the opened tab

Actual results:
- Safe area is not respected for URLBar buttons.

Expected results:
- Both the back button and the menu button need to be outside of the safe area insets. The same applies to the QR code button when the url bar is active.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Can you re-test this?

Comment 2

[Simon Basca [:SimonB]]

This is still reproducible on beta 11.0(9266). 

Here are the STR simplified:
1. Launch Firefox in landscape
2. Open tabs tray
3. Tap on the opened tab

After opening a new tab the safe area is respected but going to tabs tray while in landscape and tapping on a tab reproduces the issue.

Here is a video of the issue: https://www.youtube.com/watch?v=dhK9AzHiFac

Comment 3

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8958639 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/68ce6561fb0fafc5f790b63e55b6bde228f98bf0