Closed Bug 1439953 Opened 2 years ago Closed 2 years ago

Fix the URL to cbindgen repo in webrender_ffi_generated.h

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

The repository is at eqrion/cbindgen not rlhunt/cbindgen.
For some reason the latest published 0.4.0 is giving syntax errors on mozilla-central, and we are still in limbo with the next update which fixes it so I only updated cbindgen.toml.
You can change the generated header manually if you want. The way I do it in my WR update try pushes is I apply the patch at [1], run cbindgen, and then unapply the patch. That works around the syntax errors.

[1] https://hg.mozilla.org/try/rev/a94db6a509c2112147aa12381c7fac8c1aebf4fc
Comment on attachment 8952743 [details]
Update the github repository for cbindgen. (bug 1439953, )

https://reviewboard.mozilla.org/r/221974/#review227838
Attachment #8952743 - Flags: review?(bugmail) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb347a5cbc8c
Update the github repository for cbindgen in comments. (bug 1439953, r=kats) DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/bb347a5cbc8c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.