Closed Bug 1440073 Opened 6 years ago Closed 6 years ago

Intermittent browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js | loopback image not yet loaded - false == true -

Categories

(Firefox :: Site Identity, defect, P1)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jkt)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1440073 - Clear images from cache to fix --verify testing of browser_no_mcb_for_loopback.js
59 bytes, text/x-review-board-request
johannh
: review+
Details 
Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=163514451&repo=autoland

https://queue.taskcluster.net/v1/task/Eka6C6OySxm6fsjOgessJA/runs/0/artifacts/public/logs/live_backing.log

11:55:50     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “http://127.0.0.1:8/test.js”." {file: "https://example.com/browser/browser/base/content/test/siteIdentity/test_no_mcb_for_loopback.html" line: 40}]
11:55:50     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “http://[::1]:8/test.js”." {file: "https://example.com/browser/browser/base/content/test/siteIdentity/test_no_mcb_for_loopback.html" line: 41}]
11:55:50     INFO - Console message: [JavaScript Warning: "Use of nsIFile in content process is deprecated." {file: "resource://gre/modules/FileUtils.jsm" line: 170}]
11:55:50     INFO - Console message: [JavaScript Error: "TypeError: NetworkError when attempting to fetch resource."]
11:55:50     INFO - Console message: [JavaScript Error: "TypeError: NetworkError when attempting to fetch resource."]
11:55:50     INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js | hasMixedDisplayContentBlocked not set - false == false - 
11:55:50     INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js | hasMixedActiveContentBlocked not set - false == false - 
11:55:50     INFO - Buffered messages finished
11:55:50     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js | loopback image not yet loaded - false == true - 
11:55:50     INFO - Stack trace:
11:55:50     INFO - resource://testing-common/content-task.js line 50 > eval:null:8
11:55:50     INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js | loopback image loaded from cache - true == true -
Assignee: nobody → jkt
This was worsened by Bug 1435733, I was just in the process of filing this as I expected this. I think we should just disable for debug builds for now.
Hm, I'm not sure what to make of this. Jonathan, only about half of the failures are on debug, are you sure this patch will help fix the bug? I'm happy to r+ this if we decide to mark the bug leave-open.

Natalia, why is this bug titled "permafailing"? The orangefactor page does not suggest it is a perma-failure (though very common) and it succeeds for me locally.
Flags: needinfo?(ncsoregi)
Flags: needinfo?(jkt)
Status: NEW → ASSIGNED
Priority: P5 → P1
I could only see this failing on --verify debug builds for myself in the trys I was doing for the other bug.

I'll take another look into if we can do something better than disable.
Flags: needinfo?(jkt)
Comment on attachment 8952897 [details]
Bug 1440073 - Clear images from cache to fix --verify testing of browser_no_mcb_for_loopback.js

https://reviewboard.mozilla.org/r/222138/#review228428

Nice, great find, I wouldn't have thought of that! I wonder if you should clear the image cache at the start of the test instead of as cleanup (or both)...

::: browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js:28
(Diff revision 2)
>  const PREF_BLOCK_DISPLAY = "security.mixed_content.block_display_content";
>  const PREF_UPGRADE_DISPLAY = "security.mixed_content.upgrade_display_content";
>  const PREF_BLOCK_ACTIVE = "security.mixed_content.block_active_content";
>  
> +function clearAllImageCaches() {
> +  var tools = Cc["@mozilla.org/image/tools;1"]

let

::: browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js:29
(Diff revision 2)
>  const PREF_UPGRADE_DISPLAY = "security.mixed_content.upgrade_display_content";
>  const PREF_BLOCK_ACTIVE = "security.mixed_content.block_active_content";
>  
> +function clearAllImageCaches() {
> +  var tools = Cc["@mozilla.org/image/tools;1"]
> +                .getService(SpecialPowers.Ci.imgITools);

Do you really need SpecialPowers.Ci?

::: browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js:30
(Diff revision 2)
>  const PREF_BLOCK_ACTIVE = "security.mixed_content.block_active_content";
>  
> +function clearAllImageCaches() {
> +  var tools = Cc["@mozilla.org/image/tools;1"]
> +                .getService(SpecialPowers.Ci.imgITools);
> +  var imageCache = tools.getImgCacheForDocument(window.document);

let
Attachment #8952897 - Flags: review?(jhofmann) → review+
@johannh It has failed with every retrigger on the following push:
 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=275404b9ec613bd75b1a7178f2fa26b4b90079ba&selectedJob=163514451&filter-searchStr=TV on those two specific platforms, and I have marked it as permafailing(for as far as my understanding goes). Will switch it to intermittent, thank you for the heads up.
Flags: needinfo?(ncsoregi)
Summary: Permafailing browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js | loopback image not yet loaded - false == true - → Intermittent browser/base/content/test/siteIdentity/browser_no_mcb_for_loopback.js | loopback image not yet loaded - false == true -
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ae7363be20b
Clear images from cache to fix --verify testing of browser_no_mcb_for_loopback.js r=johannh
https://hg.mozilla.org/mozilla-central/rev/1ae7363be20b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: