Remove calls to ChromeUtils.import("resource://gre/modules/Console.jsm") that only import the 'console' global

RESOLVED FIXED in Firefox 60

Status

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Blocks 1 bug)

Trunk
Firefox 60
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

a year ago
Calls that construct their own ConsoleAPI will need a bit of extra work (see patch in Bug 1430810), but in the meantime we should be able to get rid of any callers that just import the 'console' global.
Assignee

Updated

a year ago
Depends on: 1439686
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8952895 [details]
Bug 1440094 - Allow `console` as a global for eslint;

https://reviewboard.mozilla.org/r/222132/#review229632
Attachment #8952895 - Flags: review?(dtownsend) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8952896 [details]
Bug 1440094 - Remove imports to Console.jsm that only access the 'console' object;

https://reviewboard.mozilla.org/r/222134/#review229638
Attachment #8952896 - Flags: review?(dtownsend) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

a year ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c562a143086
Allow `console` as a global for eslint;r=mossop
https://hg.mozilla.org/integration/autoland/rev/a3fce9084969
Remove imports to Console.jsm that only access the 'console' object;r=mossop

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c562a143086
https://hg.mozilla.org/mozilla-central/rev/a3fce9084969
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.