Closed
Bug 1440094
Opened 6 years ago
Closed 6 years ago
Remove calls to ChromeUtils.import("resource://gre/modules/Console.jsm") that only import the 'console' global
Categories
(DevTools :: Console, enhancement)
DevTools
Console
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Calls that construct their own ConsoleAPI will need a bit of extra work (see patch in Bug 1430810), but in the meantime we should be able to get rid of any callers that just import the 'console' global.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8952895 [details] Bug 1440094 - Allow `console` as a global for eslint; https://reviewboard.mozilla.org/r/222132/#review229632
Attachment #8952895 -
Flags: review?(dtownsend) → review+
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8952896 [details] Bug 1440094 - Remove imports to Console.jsm that only access the 'console' object; https://reviewboard.mozilla.org/r/222134/#review229638
Attachment #8952896 -
Flags: review?(dtownsend) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=083d7dbf1bfb0a895441433a282eeda87b16cca8
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c562a143086 Allow `console` as a global for eslint;r=mossop https://hg.mozilla.org/integration/autoland/rev/a3fce9084969 Remove imports to Console.jsm that only access the 'console' object;r=mossop
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3c562a143086 https://hg.mozilla.org/mozilla-central/rev/a3fce9084969
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•