Closed Bug 1440102 Opened 6 years ago Closed 6 years ago

Perma devtools/client/debugger/new/test/mochitest/browser_dbg-babel.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(DevTools :: Debugger, defect, P5)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: nataliaCs, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Bug 1440102 - increase timeout for browser_dbg-babel-scopes.js and reenable on win ccov;
59 bytes, text/x-review-board-request
jlast
: review+
Details 
+++ This bug was initially created as a clone of Bug #1438797 +++

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=162525804&repo=mozilla-central

https://queue.taskcluster.net/v1/task/NKx5DPuYTpioz6CM2awT-A/runs/0/artifacts/public/logs/live_backing.log

This is failing on M-C / "windows10-64-ccov debug" and was introduced with the push  (https://hg.mozilla.org/integration/mozilla-inbound/rev/7598d4ba066f) made for Bug 1438014

Started failing on Linux as well
Recent failure log https://treeherder.mozilla.org/logviewer.html#?job_id=163530759&repo=mozilla-central&lineNumber=3342

[task 2018-02-21T21:21:26.794Z] 21:21:26     INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-babel.js | Breakpoint reverted - 
[task 2018-02-21T21:21:26.794Z] 21:21:26     INFO - Resuming
[task 2018-02-21T21:21:26.795Z] 21:21:26     INFO - Buffered messages logged at 21:21:25
[task 2018-02-21T21:21:26.795Z] 21:21:26     INFO - TEST-PASS | devtools/client/debugger/new/test/mochitest/browser_dbg-babel.js | Ran tests for webpack-modules-es6 at line 17 column 2 - 
[task 2018-02-21T21:21:26.796Z] 21:21:26     INFO - Leaving test bound 
[task 2018-02-21T21:21:26.796Z] 21:21:26     INFO - Removing tab.
[task 2018-02-21T21:21:26.797Z] 21:21:26     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2018-02-21T21:21:26.798Z] 21:21:26     INFO - Buffered messages logged at 21:21:26
[task 2018-02-21T21:21:26.798Z] 21:21:26     INFO - Got event: 'TabClose' on [object XULElement].
[task 2018-02-21T21:21:26.799Z] 21:21:26     INFO - Tab removed and finished closing
[task 2018-02-21T21:21:26.799Z] 21:21:26     INFO - Buffered messages finished
[task 2018-02-21T21:21:26.800Z] 21:21:26     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/new/test/mochitest/browser_dbg-babel.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2018-02-21T21:21:26.800Z] 21:21:26     INFO - GECKO(1067) | MEMORY STAT | vsize 2590MB | residentFast 699MB | heapAllocated 159MB
[task 2018-02-21T21:21:26.801Z] 21:21:26     INFO - TEST-OK | devtools/client/debugger/new/test/mochitest/browser_dbg-babel.js | took 289130ms
I think this is just a regular timeout issue.

This test already has requestLongerTimeout(3); and when looking at successful runs on Linux debug, I found runtimes of 230 seconds.

-> https://public-artifacts.taskcluster.net/MQTflfINQY2JmcuD71x1Ig/0/public/logs/live_backing.log

"INFO - TEST-OK | devtools/client/debugger/new/test/mochitest/browser_dbg-babel.js | took 228942ms"

I thought the timeout threshold was 45 seconds, so normally a test with requestLongerTimeout(3) should fail if running for more than 180 seconds?

Disabling the test on windows+ccov in Bug 1438014 was probably not necessary. We should either extend the timeout or split.
Looks like the timeout has been bumped to 90 seconds on debug platforms in Bug 1329034.

Plus, I thought requestLongerTimeout meant [initial timeout + (3 x timeout)] before failing, but apparently it's just a factor. Which means that on debug platforms, this test should effectively timeout after 270seconds. 230s is pretty close to that considering how much performance can vary on debug platforms.
Comment on attachment 8953067 [details]
Bug 1440102 - increase timeout for browser_dbg-babel-scopes.js and reenable on win ccov;

https://reviewboard.mozilla.org/r/222342/#review230226

Thanks! Lets give this a try
Attachment #8953067 - Flags: review?(jlaster) → review+
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 481b4c094914d62c7a1f0ee006630018d47cb3fa -d d97c0342dc0d: rebasing 450557:481b4c094914 "Bug 1440102 - increase timeout for browser_dbg-babel.js and reenable on win ccov;r=jlast" (tip)
merging devtools/client/debugger/new/test/mochitest/browser.ini
merging devtools/client/debugger/new/test/mochitest/browser_dbg-babel-scopes.js and devtools/client/debugger/new/test/mochitest/browser_dbg-babel.js to devtools/client/debugger/new/test/mochitest/browser_dbg-babel-scopes.js
warning: conflicts while merging devtools/client/debugger/new/test/mochitest/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/195a3f9c9d2b
increase timeout for browser_dbg-babel-scopes.js and reenable on win ccov;r=jlast
https://hg.mozilla.org/mozilla-central/rev/195a3f9c9d2b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: