Closed
Bug 1440143
Opened 8 years ago
Closed 8 years ago
Add application/json Content-Type to Lando pingback request
Categories
(Conduit Graveyard :: Transplant, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: imadueme, Assigned: imadueme)
References
Details
Attachments
(1 file)
Lando uses the Connexions library which is very strict about incoming request data. It is strict so that it can match the request with the appropriate swagger specification.
When transplant submits the pingback to lando, it does so without any Content-Type header assuming that Lando will figure it out. Connexions does not like this add immediately returns a 415 HTTP error. We should specify the application/json Content-Type.
|
Assignee | |
Comment 1•8 years ago
|
||
Phabricator revision didn't get synced: https://phabricator.services.mozilla.com/D635
|
||
Comment 2•8 years ago
|
||
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8953119 [details]
autoland: add application/json content type to lando pingback request (bug 1440143).
Byron Jones ‹:glob› has approved the revision.
https://phabricator.services.mozilla.com/D635
Attachment #8953119 -
Flags: review+
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1ae17f4c9ce6
autoland: add application/json content type to lando pingback request r=glob
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
https://github.com/mozilla-conduit/conduit-autoland-transplant/commit/c9be65678ac9b20a396d7f64e6ca66bbaea87cf1
i'll deploy to prod early next week.
|
||
Updated•8 years ago
|
Product: MozReview → Conduit
|
|
||
Updated•2 years ago
|
Product: Conduit → Conduit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•