Remove unused menubutton-item binding

RESOLVED FIXED in Firefox 60

Status

()

RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: bgrins, Assigned: enndeakin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [xbl-available])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
This is bound to `menuitem.menuitem-non-iconic`, but I can't find any hits of menuitem-non-iconic besides the css selector attaching the binding.

* https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/toolkit/content/xul.css#376
(Reporter)

Comment 1

a year ago
comm-central has a single hit in `calendar/` so this'll likely need to be ported (or change the element to not use it anymore): https://searchfox.org/comm-central/search?q=menuitem-non-iconic&path=
Assignee: nobody → enndeakin
(Assignee)

Comment 2

a year ago
The reference in calendar isn't affected since the class is incorrectly applied to a menulist rather than a menuitem.
Attachment #8956076 - Flags: review?(bgrinstead)
(Reporter)

Comment 3

a year ago
Comment on attachment 8956076 [details] [diff] [review]
menuitem-unused-binding

Review of attachment 8956076 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8956076 - Flags: review?(bgrinstead) → review+

Comment 4

a year ago
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33d3f93924ac
remove unused menubutton-item binding, r=bgrins

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/33d3f93924ac
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
status-firefox60: --- → fixed
tracking-seamonkey2.15: --- → ---
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.