1440146 - Remove unused menubutton-item binding

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Brian Grinstead [:bgrins]]

This is bound to `menuitem.menuitem-non-iconic`, but I can't find any hits of menuitem-non-iconic besides the css selector attaching the binding.

* https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/toolkit/content/xul.css#376

Comment 1

[Brian Grinstead [:bgrins]]

comm-central has a single hit in `calendar/` so this'll likely need to be ported (or change the element to not use it anymore): https://searchfox.org/comm-central/search?q=menuitem-non-iconic&path=

Comment 2

[Neil Deakin]

Attachment: menuitem-unused-binding

The reference in calendar isn't affected since the class is incorrectly applied to a menulist rather than a menuitem.

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8956076 [details] [diff] [review]
menuitem-unused-binding

Review of attachment 8956076 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33d3f93924ac
remove unused menubutton-item binding, r=bgrins

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/33d3f93924ac

Comment 6

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336