1440209 - Navigating away from the last starred failure should clear the &selectedJob

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Phil Ringnalda (:philor)]

Last little niggle after the fix for bug 1438555.

STR:
1. Load https://treeherder.allizom.org/ and find a push with only a few failures so you don't have to star too many, select that push, type U to get only-starred showing.
2. Go through the failures by typing N, starring them. After you star the last one, type N again

Expected: previous behavior was a popup message, not entirely necessary though I always treated it as a pat on the back, about "no more unstarred failures to select", along with a glorious empty screen

Actual: when you star the last one, the new behavior is to leave it showing as starred, then when you type N, it disappears, you don't navigate away from it, and then on the next autorefresh of the page, it comes back again showing as starred instead of disappearing for good. To get to a blank screen you have to hit Esc to close the pinboard and then N to deselect the last job.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3518

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8973015 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3518

Here's another little one for ya.  Sorry for the barrage today!  Figured I'd hit some low-hanging fruit.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2d8d3eb4e32072cde2fb60649d2215397618b549
Bug 1440209 - Fix clear job when no more unclassified failures