Closed Bug 1440292 Opened 6 years ago Closed 6 years ago

remove gUIDensity.setCurrentMode unused

Categories

(Firefox :: Toolbars and Customization, enhancement)

Product:
Firefox
Component:
Toolbars and Customization
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: aryx, Assigned: manishkk)

Details

Attachments

(1 file, 1 obsolete file)

PatchV2_Bug1440292
759 bytes, patch
johannh
: review+
Details | Diff | Splinter Review 
Bug 1350210 added gUIDensity.setCurrentMode: https://hg.mozilla.org/mozilla-central/rev/43d356910d30#l1.96

This looks unused.

Johann, is this used by e.g. system add-ons, an oversight by me or can this be removed?
Flags: needinfo?(jhofmann)
Yeah, that looks unused to me, too :)
Flags: needinfo?(jhofmann)
:aryx

Do I need to remove these line from here only or anywhere else?


https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js?q=setCurrentMode&redirect_type=single#5729-5731
Flags: needinfo?(aryx.bugmail)
Only lines from the setCurrentMode definition, there is no caller. Thank you.
Flags: needinfo?(aryx.bugmail)
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1440292 (obsolete) — — Splinter Review 
Please review
Attachment #8966168 - Flags: review?(aryx.bugmail)
Comment on attachment 8966168 [details] [diff] [review]
Patch_Bug1440292

Review of attachment 8966168 [details] [diff] [review]:
-----------------------------------------------------------------

Please fix the issue and submit an updated patch.

::: browser/base/content/browser.js
@@ +5725,4 @@
>    },
>  
>    setCurrentMode(mode) {
> +    },

The whole setCurrentMode method has to be removed, not only its content.
Attachment #8966168 - Flags: review?(aryx.bugmail) → review-

        Attachment #8966168 -
        Attachment is obsolete: true

        Attachment #8966171 -
        Flags: review?(aryx.bugmail)

    
    

    
  
Comment on attachment 8966171 [details] [diff] [review]
PatchV2_Bug1440292

Review of attachment 8966171 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but changes need an official reviewer.

        Attachment #8966171 -
        Flags: review?(aryx.bugmail) → review?(jhofmann)

    
    

    
  
Comment on attachment 8966171 [details] [diff] [review]
PatchV2_Bug1440292

Review of attachment 8966171 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!

        Attachment #8966171 -
        Flags: review?(jhofmann) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cba61d601f1
Remove unused gUIDensity.setCurrentMode. r=johannh
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9cba61d601f1
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox61:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: