1440292 - remove gUIDensity.setCurrentMode unused

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1350210 added gUIDensity.setCurrentMode: https://hg.mozilla.org/mozilla-central/rev/43d356910d30#l1.96

This looks unused.

Johann, is this used by e.g. system add-ons, an oversight by me or can this be removed?

Comment 1

[Johann Hofmann [:johannh]]

Yeah, that looks unused to me, too :)

Comment 2

[Manish [:manishkk]]

:aryx

Do I need to remove these line from here only or anywhere else?


https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js?q=setCurrentMode&redirect_type=single#5729-5731

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Only lines from the setCurrentMode definition, there is no caller. Thank you.

Comment 4

[Manish [:manishkk]]

Attachment: Patch_Bug1440292

Please review

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8966168 [details] [diff] [review]
Patch_Bug1440292

Review of attachment 8966168 [details] [diff] [review]:
-----------------------------------------------------------------

Please fix the issue and submit an updated patch.

::: browser/base/content/browser.js
@@ +5725,4 @@
>    },
>  
>    setCurrentMode(mode) {
> +    },

The whole setCurrentMode method has to be removed, not only its content.

Comment 6

[Manish [:manishkk]]

Attachment: PatchV2_Bug1440292

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8966171 [details] [diff] [review]
PatchV2_Bug1440292

Review of attachment 8966171 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but changes need an official reviewer.

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8966171 [details] [diff] [review]
PatchV2_Bug1440292

Review of attachment 8966171 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cba61d601f1
Remove unused gUIDensity.setCurrentMode. r=johannh

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9cba61d601f1