Open Bug 1440300 Opened 3 years ago Updated 3 years ago

[wpt-sync] Sync PR 9629 - Revert "Support VTTCue.positionAlign and lineAlign for WebVTT"

Categories

(Testing :: web-platform-tests, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9629 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9629
Details from upstream follow.

Philip Jägenstedt wrote:
>  Revert "Support VTTCue.positionAlign and lineAlign for WebVTT"
>  
>  This reverts commit 2c1d466d78db6df8b4c9fbe37ac5af1cb135bf34.
>  
>  Reason for revert: https://crbug.com/814710
>  
>  Original change's description:
>  > Support VTTCue.positionAlign and lineAlign for WebVTT
>  > 
>  > Implement VTTCue.[positionAlign and lineAlign] for WebVTT
>  > Updated parsing logic
>  > Exposed DOM API's
>  > Updated Layout algorithm
>  > Updated test expected results
>  > 
>  > Bug: 633690
>  > Change-Id: I49970c068c53b462243ba8c7f314261b0e6455ce
>  > Reviewed-on: https://chromium-review.googlesource.com/756142
>  > Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
>  > Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
>  > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
>  > Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
>  > Reviewed-by: Fredrik Söderquist <fs@opera.com>
>  > Cr-Commit-Position: refs/heads/master@{#525659}
>  
>  TBR=fs@opera.com,chrishtr@chromium.org,srirama.m@samsung.com,foolip@chromium.org,k2.nagaraju@samsung.com
>  
>  # Not skipping CQ checks because original CL landed > 1 day ago.
>  
>  Bug: 633690
>  Change-Id: Ib9f0b3dd1a4b679076ec55ec635337551f8b8806
>  
>  Reviewed-on: https://chromium-review.googlesource.com/931481
>  WPT-Export-Revision: 6d6f7736dc1228a2fa8be245ee26b513ca7e142c
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/541d7d8a63cd
[wpt PR 9629] - Revert "Support VTTCue.positionAlign and lineAlign for WebVTT", a=testonly
You need to log in before you can comment on or make changes to this bug.