Closed Bug 1440346 Opened 3 years ago Closed 3 years ago

Add a legend to the ASCII art tree that SyncedBookmarkMirror outputs in the log

Categories

(Firefox :: Sync, enhancement, P3)

Product:
Firefox
Component:
Sync
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

Details

Attachments

(1 file)

Bug 1440346 - Replace abbreviated strings in the sync bookmark mirror's tree log with full names
59 bytes, text/x-review-board-request
lina
: review+
Details 
It's fairly opaque as it is. A short legend would go a long way.
Priority: -- → P3
In IRC markh requested that these include the URLs for bookmarks as well (mostly for mnemonic value). These are already only logged on TRACE so the additional PII isn't a problem. It might make sense to log folder names as well.

It's possible we'd want to avoid logging more than N (for some smallish N) characters of urls though.
Comment #1 should instead be done as part of bug 1444304, since it's nontrivial.
I'm doing this now since I want better logs.
Assignee: nobody → tchiovoloni
Comment on attachment 8957719 [details]
Bug 1440346 - Replace abbreviated strings in the sync bookmark mirror's tree log with full names

https://reviewboard.mozilla.org/r/226674/#review232470

Thanks!

::: toolkit/components/places/SyncedBookmarksMirror.jsm:3062
(Diff revision 1)
>     * are prefixed with "~".
>     *
>     * @return {String}
>     */
>    toASCIITreeString() {
>      return this.root.toASCIITreeString() + "\n" + Array.from(this.deletedGuids,

Should we change this to `Deleted: A, B, C`, instead of `~A (deleted), ~B (deleted), ~C (deleted)`?
Attachment #8957719 - Flags: review?(kit) → review+
Comment on attachment 8957719 [details]
Bug 1440346 - Replace abbreviated strings in the sync bookmark mirror's tree log with full names

https://reviewboard.mozilla.org/r/226674/#review232470

> Should we change this to `Deleted: A, B, C`, instead of `~A (deleted), ~B (deleted), ~C (deleted)`?

Good point!
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30b4097734ce
Replace abbreviated strings in the sync bookmark mirror's tree log with full names r=kitcambridge
https://hg.mozilla.org/mozilla-central/rev/30b4097734ce
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.