1440361 - Don't send empty WR resource update transactions to the compositor

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

We call RemoveExpiredFontKeys on every transaction [1] but often there are no fonts to actually expire. In those cases we still send a resource update message to the compositor [2] but it's empty. So we should just not do that, as it's a waste.

[1] https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/gfx/layers/wr/WebRenderLayerManager.cpp#255
[2] https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/gfx/layers/wr/WebRenderBridgeChild.cpp#404

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1440361 - Reduce unnecessary IPC traffic from RemoveExpiredFontKeys which can produce empty resource updates.

Review commit: https://reviewboard.mozilla.org/r/222390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222390/

Comment 2

[Lee Salzman [:lsalzman]]

Comment on attachment 8953108 [details]
Bug 1440361 - Reduce unnecessary IPC traffic from RemoveExpiredFontKeys which can produce empty resource updates.

https://reviewboard.mozilla.org/r/222390/#review228310

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8bfa3b81685
Reduce unnecessary IPC traffic from RemoveExpiredFontKeys which can produce empty resource updates. r=lsalzman

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b8bfa3b81685