Closed Bug 1440361 Opened 4 years ago Closed 4 years ago

Don't send empty WR resource update transactions to the compositor

Categories

(Core :: Graphics: WebRender, enhancement)

Other Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

We call RemoveExpiredFontKeys on every transaction [1] but often there are no fonts to actually expire. In those cases we still send a resource update message to the compositor [2] but it's empty. So we should just not do that, as it's a waste.

[1] https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/gfx/layers/wr/WebRenderLayerManager.cpp#255
[2] https://searchfox.org/mozilla-central/rev/9a8d3f8191b15cdca89a7ce044c7bea2dd0462dc/gfx/layers/wr/WebRenderBridgeChild.cpp#404
Comment on attachment 8953108 [details]
Bug 1440361 - Reduce unnecessary IPC traffic from RemoveExpiredFontKeys which can produce empty resource updates.

https://reviewboard.mozilla.org/r/222390/#review228310
Attachment #8953108 - Flags: review?(lsalzman) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8bfa3b81685
Reduce unnecessary IPC traffic from RemoveExpiredFontKeys which can produce empty resource updates. r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/b8bfa3b81685
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.