1440362 - Phabricator Revisions aren't being synced with bugs in some cases

Status: RESOLVED WORKSFORME

(Conduit :: Phabricator, defect, P1)

Description

[Israel Madueme [:imadueme]]

Examples, look at the revision creation time and the time it becomes public (either manually or by phab-bot).

https://phabricator.services.mozilla.com/D614 - never synced
https://phabricator.services.mozilla.com/D615 - never synced
https://phabricator.services.mozilla.com/D618 - never synced
https://phabricator.services.mozilla.com/D619 - never synced
https://phabricator.services.mozilla.com/D620 - successfully synced immediately
https://phabricator.services.mozilla.com/D621 - successfully synced immediately
https://phabricator.services.mozilla.com/D622 - successfully synced immediately
https://phabricator.services.mozilla.com/D633 - successfully synced immediately
https://phabricator.services.mozilla.com/D634 - never synced

Comment 1

[Israel Madueme [:imadueme]]

https://phabricator.services.mozilla.com/D635 - never synced

Comment 2

[Israel Madueme [:imadueme]]

Actually https://phabricator.services.mozilla.com/D634 was synced later after I made it public (see the attachment on https://bugzilla.mozilla.org/show_bug.cgi?id=1437154) (this was an emergency fix so I didn't wait long just 1 minute).

Comment 3

[Israel Madueme [:imadueme]]

And it should be noted that all the never synced revisions except (D635) did later get attachments created, but very late as you can see from the time stamps.

Comment 4

[Israel Madueme [:imadueme]]

I haven't had this bug in a while, has anything changed?

Comment 5

[David Lawrence [:dkl]]

(In reply to Israel Madueme [:imadueme] from comment #4)
> I haven't had this bug in a while, has anything changed?

Yeah, nothing substantial has changed code wise. I was going to ping you and see if you have seen any more issues so it seems it has cleared up on its own. In my investigation, I was never able to pin down any reason for the problem either in logs or looking at phab-bot permissions. For some reason when phab-bot on BMO was looking for the latest transactions, your changes would not show up in the results from the API. But if I did the same query using the conduit API via the web UI as the phab-bot user, they would show up properly.

Anyway, please let me know if you see anything else like this in the future.

dkl